This is an archive of the discontinued LLVM Phabricator instance.

Differential D109224

[hwasan] Test use-after-scope with -fno-exceptions.
ClosedPublic

Authored by fmayer on Sep 3 2021, 4:05 AM.

Details

Reviewers
hctim
Commits
rG2706b1a6e2df: [hwasan] Test use-after-scope with -fno-exceptions.

Diff Detail

Unit TestsFailed

TimeTest
0 msx64 windows > Clang.CodeGen/aarch64-sve-intrinsics::acle_sve_st1b.c
20 msx64 windows > Clang.CodeGen/aarch64-sve-intrinsics::acle_sve_st1h.c
0 msx64 windows > Clang.CodeGen/aarch64-sve-intrinsics::acle_sve_st1w.c

Event Timeline

fmayer requested review of this revision.Sep 3 2021, 4:05 AM
fmayer created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptSep 3 2021, 4:05 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
fmayer added a reviewer: hctim.Sep 3 2021, 4:06 AM
Harbormaster completed remote builds in B122484: Diff 370536.Sep 3 2021, 4:39 AM
hctim accepted this revision.Sep 3 2021, 2:18 PM

LGTM - Is this providing coverage that otherwise wasn't being found? Did you find a bug in an upcoming patchset?

This revision is now accepted and ready to land.Sep 3 2021, 2:18 PM
• hafixo added a commit: rCRT373035: hwasan: Compatibility fixes for short granules..Sep 6 2021, 12:44 AM
• hafixo added a commit: rGc336557f0238: hwasan: Compatibility fixes for short granules..Sep 6 2021, 12:47 AM
fmayer added a comment.Sep 6 2021, 2:05 AM
In D109224#2983173, @hctim wrote:

LGTM - Is this providing coverage that otherwise wasn't being found? Did you find a bug in an upcoming patchset?

This is because the std::vector case gets compiled quite differently without exceptions, given that e.g. Android is built without exceptions, there should be a test that verifies that actually works.
But no, this didn't find any bug so far.

This revision was landed with ongoing or failed builds.Sep 6 2021, 2:10 AM
Closed by commit rG2706b1a6e2df: [hwasan] Test use-after-scope with -fno-exceptions. (authored by fmayer). · Explain Why
This revision was automatically updated to reflect the committed changes.
fmayer added a commit: rG2706b1a6e2df: [hwasan] Test use-after-scope with -fno-exceptions..
thopre removed a commit: rGc336557f0238: hwasan: Compatibility fixes for short granules..Sep 7 2021, 2:47 AM
thopre removed a commit: rCRT373035: hwasan: Compatibility fixes for short granules..Sep 7 2021, 2:51 AM

Revision Contents

PathSize
compiler-rt/
test/
hwasan/
TestCases/
14 lines

Diff 370536

compiler-rt/test/hwasan/TestCases/use-after-scope-types.cpp

// This is the ASAN test of the same name ported to HWAsan. // This is the ASAN test of the same name ported to HWAsan.
// RUN: %clangxx_hwasan -mllvm -hwasan-use-after-scope -std=c++11 -O0 %s -o %t // RUN: %clangxx_hwasan -mllvm -hwasan-use-after-scope -std=c++11 -O0 %s -o %t
// RUN: %clangxx_hwasan -fno-exceptions -mllvm -hwasan-use-after-scope -std=c++11 -O0 %s -o %t-noexcept
// RUN: not %run %t 0 2>&1 | FileCheck %s // RUN: not %run %t 0 2>&1 | FileCheck %s
// RUN: not %run %t 1 2>&1 | FileCheck %s // RUN: not %run %t 1 2>&1 | FileCheck %s
// RUN: not %run %t 2 2>&1 | FileCheck %s // RUN: not %run %t 2 2>&1 | FileCheck %s
// RUN: not %run %t 3 2>&1 | FileCheck %s // RUN: not %run %t 3 2>&1 | FileCheck %s
// RUN: not %run %t 4 2>&1 | FileCheck %s // RUN: not %run %t 4 2>&1 | FileCheck %s
// RUN: not %run %t 5 2>&1 | FileCheck %s // RUN: not %run %t 5 2>&1 | FileCheck %s
// RUN: not %run %t 6 2>&1 | FileCheck %s // RUN: not %run %t 6 2>&1 | FileCheck %s
// RUN: not %run %t 7 2>&1 | FileCheck %s // RUN: not %run %t 7 2>&1 | FileCheck %s
// RUN: not %run %t 8 2>&1 | FileCheck %s // RUN: not %run %t 8 2>&1 | FileCheck %s
// RUN: not %run %t 9 2>&1 | FileCheck %s // RUN: not %run %t 9 2>&1 | FileCheck %s
// RUN: not %run %t 10 2>&1 | FileCheck %s // RUN: not %run %t 10 2>&1 | FileCheck %s
// RUN: not %run %t-noexcept 0 2>&1 | FileCheck %s
// RUN: not %run %t-noexcept 1 2>&1 | FileCheck %s
// RUN: not %run %t-noexcept 2 2>&1 | FileCheck %s
// RUN: not %run %t-noexcept 3 2>&1 | FileCheck %s
// RUN: not %run %t-noexcept 4 2>&1 | FileCheck %s
// RUN: not %run %t-noexcept 5 2>&1 | FileCheck %s
// RUN: not %run %t-noexcept 6 2>&1 | FileCheck %s
// RUN: not %run %t-noexcept 7 2>&1 | FileCheck %s
// RUN: not %run %t-noexcept 8 2>&1 | FileCheck %s
// RUN: not %run %t-noexcept 9 2>&1 | FileCheck %s
// RUN: not %run %t-noexcept 10 2>&1 | FileCheck %s
// REQUIRES: aarch64-target-arch // REQUIRES: aarch64-target-arch
// REQUIRES: stable-runtime // REQUIRES: stable-runtime
#include <stdlib.h> #include <stdlib.h>
#include <string> #include <string>
#include <vector> #include <vector>
template <class T> template <class T>
▲ Show 20 Lines • Show All 58 Lines • Show Last 20 Lines