This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][Profile] Wait for child threads in set-file-object test
ClosedPublic

Authored by DavidSpickett on Sep 3 2021, 4:02 AM.

Details

Summary

We've been seeing this test return 31 instead of 32 for the "functions"
line in this test on our AArch64 bots.

One possible cause is some of the children not finishing in time
before the llvm-profdata commands are run, if the machine is heavily loaded.

Wait for all the children to finish before exiting the parent.

Diff Detail

Event Timeline

DavidSpickett created this revision.Sep 3 2021, 4:02 AM
DavidSpickett requested review of this revision.Sep 3 2021, 4:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 3 2021, 4:02 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Rebase onto main.

Temporarily disabled the test for arm linux in 8b86f8a3256a59cbaa12858cb0842025d48f549f.

zequanwu accepted this revision.Sep 3 2021, 10:35 AM

LGTM, Thanks!

This revision is now accepted and ready to land.Sep 3 2021, 10:35 AM
This revision was landed with ongoing or failed builds.Sep 3 2021, 11:49 AM
This revision was automatically updated to reflect the committed changes.

I committed on your behalf to unblock the bots.