This is an archive of the discontinued LLVM Phabricator instance.

[profile] Extend binary id profile test
AcceptedPublic

Authored by gulfem on Sep 1 2021, 6:59 PM.

Details

Reviewers
phosek
vsk
davidxl
Summary

After including binary ids in profiles (https://reviews.llvm.org/D102039),
we found out that binary id changes are not exercising:

  1. Profile merging from various processes by using %m specifier (Fixed in https://reviews.llvm.org/D107143)
  2. Counter relocations by using %c specifier (Fixed in https://reviews.llvm.org/D108608)

This patch extends binary-id test to exercise the issues mentioned above.

Diff Detail

Event Timeline

gulfem requested review of this revision.Sep 1 2021, 6:59 PM
gulfem created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptSep 1 2021, 6:59 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
gulfem edited the summary of this revision. (Show Details)
gulfem edited the summary of this revision. (Show Details)
phosek accepted this revision.Sep 8 2021, 12:23 AM

LGTM

compiler-rt/test/profile/Linux/binary-id.c
28

I'd consider including a call to foo() here to introduce some variation, but it's not necessary.

This revision is now accepted and ready to land.Sep 8 2021, 12:23 AM