Page MenuHomePhabricator

[libc] Add implementations of the C standard condition variable functions.
ClosedPublic

Authored by sivachandra on Aug 30 2021, 2:01 PM.

Diff Detail

Event Timeline

sivachandra created this revision.Aug 30 2021, 2:01 PM
sivachandra requested review of this revision.Aug 30 2021, 2:01 PM

I will be adding more tests but sending this out early to get feedback on the actual implementation.

Rebase and add another test.

michaelrj accepted this revision.Mon, Sep 27, 3:43 PM

LGTM

libc/src/threads/linux/CndVar.h
60

are these braces necessary?

This revision is now accepted and ready to land.Mon, Sep 27, 3:43 PM
sivachandra added inline comments.Tue, Sep 28, 1:30 PM
libc/src/threads/linux/CndVar.h
60

These are for the RAII MutexLock class instantiated on line 60.

michaelrj added inline comments.Tue, Sep 28, 1:32 PM
libc/src/threads/linux/CndVar.h
60

ah, that makes sense. All good then.

This revision was landed with ongoing or failed builds.Tue, Sep 28, 2:19 PM
This revision was automatically updated to reflect the committed changes.