This is an archive of the discontinued LLVM Phabricator instance.

[libc++][NFC] split <charconv>.
ClosedPublic

Authored by Mordante on Aug 30 2021, 10:48 AM.

Details

Reviewers
ldionne
Quuxplusone
Group Reviewers
Restricted Project
Commits
rGe983a659e51c: [libc++][NFC] split <charconv>.
Summary

This move the helper types chars_format, to_chars_result and
from_chars_result to a separate header. The first two are needed for
D70631 the third for consistency.

The header __charconv/ryu.h uses these types and it can't depend on the
types in <charconv> in a modular build. Moving them to the ryu header
would be an odd place and doesn't work since the header is included in the
middle of <charconv>.

Diff Detail

Event Timeline

Mordante created this revision.Aug 30 2021, 10:48 AM
Mordante requested review of this revision.Aug 30 2021, 10:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2021, 10:48 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Aug 30 2021, 10:56 AM
ldionne added a subscriber: ldionne.

LGTM if CI passes.

This revision is now accepted and ready to land.Aug 30 2021, 10:56 AM
Quuxplusone accepted this revision.Aug 30 2021, 10:59 AM
This revision was automatically updated to reflect the committed changes.