This is an archive of the discontinued LLVM Phabricator instance.

Differential D108895

[libcxx] Remove the locale fallback for NuttX
ClosedPublic

Authored by xiaoxiang781216 on Aug 29 2021, 12:08 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG3285c7a4364e: [libcxx] Remove the locale fallback for NuttX
Summary

Since these functions can handled by NuttX's libc now

Diff Detail

Event Timeline

xiaoxiang781216 requested review of this revision.Aug 29 2021, 12:08 PM
xiaoxiang781216 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2021, 12:08 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B121665: Diff 369333.Aug 29 2021, 12:18 PM
ldionne requested changes to this revision.Aug 30 2021, 10:47 AM
ldionne added a subscriber: ldionne.

Thanks for the cleanup! You will need to remove it from libcxx/include/CMakeLists.txt as well.

This revision now requires changes to proceed.Aug 30 2021, 10:47 AM
xiaoxiang781216 updated this revision to Diff 369669.Aug 31 2021, 3:22 AM

Updating D108895: [libcxx] Remove the locale fallback for NuttX

Herald added a subscriber: mgorny. · View Herald TranscriptAug 31 2021, 3:22 AM
xiaoxiang781216 added a comment.Aug 31 2021, 3:25 AM
In D108895#2972664, @ldionne wrote:

Thanks for the cleanup! You will need to remove it from libcxx/include/CMakeLists.txt as well.

Done.

Harbormaster completed remote builds in B121907: Diff 369669.Aug 31 2021, 4:30 AM
ldionne accepted this revision.Aug 31 2021, 6:46 AM
This revision is now accepted and ready to land.Aug 31 2021, 6:46 AM
Closed by commit rG3285c7a4364e: [libcxx] Remove the locale fallback for NuttX (authored by xiaoxiang781216, committed by ldionne). · Explain WhyAug 31 2021, 6:47 AM
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rG3285c7a4364e: [libcxx] Remove the locale fallback for NuttX.

Revision Contents

PathSize
libcxx/
include/
1 line
2 lines
__support/
nuttx/

Diff 369690

libcxx/include/CMakeLists.txt

Show First 20 Lines • Show All 244 Lines • ▼ Show 20 Linesset(files
__support/ibm/limits.h __support/ibm/limits.h
__support/ibm/locale_mgmt_aix.h __support/ibm/locale_mgmt_aix.h
__support/ibm/locale_mgmt_zos.h __support/ibm/locale_mgmt_zos.h
__support/ibm/nanosleep.h __support/ibm/nanosleep.h
__support/ibm/support.h __support/ibm/support.h
__support/ibm/xlocale.h __support/ibm/xlocale.h
__support/musl/xlocale.h __support/musl/xlocale.h
__support/newlib/xlocale.h __support/newlib/xlocale.h
__support/nuttx/xlocale.h
__support/openbsd/xlocale.h __support/openbsd/xlocale.h
__support/solaris/floatingpoint.h __support/solaris/floatingpoint.h
__support/solaris/wchar.h __support/solaris/wchar.h
__support/solaris/xlocale.h __support/solaris/xlocale.h
__support/win32/limits_msvc_win32.h __support/win32/limits_msvc_win32.h
__support/win32/locale_win32.h __support/win32/locale_win32.h
__support/xlocale/__nop_locale_mgmt.h __support/xlocale/__nop_locale_mgmt.h
__support/xlocale/__posix_l_fallback.h __support/xlocale/__posix_l_fallback.h
▲ Show 20 Lines • Show All 215 Lines • Show Last 20 Lines

libcxx/include/__locale

Show All 16 Lines
#include <utility> #include <utility>
#include <mutex> #include <mutex>
#include <cstdint> #include <cstdint>
#include <cctype> #include <cctype>
#include <locale.h> #include <locale.h>
#if defined(_LIBCPP_MSVCRT_LIKE) #if defined(_LIBCPP_MSVCRT_LIKE)
# include <cstring> # include <cstring>
# include <__support/win32/locale_win32.h> # include <__support/win32/locale_win32.h>
#elif defined(__NuttX__)
# include <__support/nuttx/xlocale.h>
#elif defined(_AIX) || defined(__MVS__) #elif defined(_AIX) || defined(__MVS__)
# include <__support/ibm/xlocale.h> # include <__support/ibm/xlocale.h>
#elif defined(__ANDROID__) #elif defined(__ANDROID__)
# include <__support/android/locale_bionic.h> # include <__support/android/locale_bionic.h>
#elif defined(__sun__) #elif defined(__sun__)
# include <xlocale.h> # include <xlocale.h>
# include <__support/solaris/xlocale.h> # include <__support/solaris/xlocale.h>
#elif defined(_NEWLIB_VERSION) #elif defined(_NEWLIB_VERSION)
▲ Show 20 Lines • Show All 1,725 Lines • Show Last 20 Lines

libcxx/include/__support/nuttx/xlocale.h

  • This file was deleted.
// -*- C++ -*-
//===-----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef _LIBCPP_SUPPORT_NUTTX_XLOCALE_H
#define _LIBCPP_SUPPORT_NUTTX_XLOCALE_H
#if defined(__NuttX__)
#include <__support/xlocale/__posix_l_fallback.h>
#include <__support/xlocale/__strtonum_fallback.h>
#endif // __NuttX__
#endif
libcxx/include/CMakeLists.txt