Page MenuHomePhabricator

xiaoxiang781216 (Xiang Xiao)
Software Architect

Projects

User does not belong to any projects.

User Details

User Since
Jul 2 2020, 5:13 AM (21 w, 3 d)

Recent Activity

Wed, Nov 18

xiaoxiang781216 added a comment to D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS.

Just FYI, you also forgot to add support/nuttx/xlocale.h to libcxx/include/CMakeLists.txt, but I realized it when applying the patch locally and added it myself.

Wed, Nov 18, 7:18 PM · Restricted Project

Tue, Nov 17

xiaoxiang781216 added a comment to D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS.

@ldionne do you have time to review the update again?

Tue, Nov 17, 9:41 PM · Restricted Project

Wed, Nov 11

xiaoxiang781216 added a comment to D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS.

@ldionne I move the toolchain macro undefinition to NuttX's Makefile, please review again.

Wed, Nov 11, 8:24 AM · Restricted Project
xiaoxiang781216 updated the diff for D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS.

Updating D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS

Wed, Nov 11, 8:21 AM · Restricted Project
xiaoxiang781216 added inline comments to D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS.
Wed, Nov 11, 6:28 AM · Restricted Project
xiaoxiang781216 added a comment to D91074: [libcxx] check _LIBCPP_PROVIDES_DEFAULT_RUNE_TABLE first in __locale.

@ ldionne NuttX's simulator is built on Ubuntu with the host gcc toolchain, and then GLIBC is defined in this case, but NuttX's libc is written from scratch and don't define _ISspace... at all.

Wed, Nov 11, 6:06 AM · Restricted Project

Mon, Nov 9

xiaoxiang781216 updated the diff for D91074: [libcxx] check _LIBCPP_PROVIDES_DEFAULT_RUNE_TABLE first in __locale.

Updating D91074: [libcxx] Check _LIBCPP_PROVIDES_DEFAULT_RUNE_TABLE first in __locale

Mon, Nov 9, 6:12 AM · Restricted Project
xiaoxiang781216 updated the diff for D91074: [libcxx] check _LIBCPP_PROVIDES_DEFAULT_RUNE_TABLE first in __locale.

Updating D91074: [libcxx] check _LIBCPP_PROVIDES_DEFAULT_RUNE_TABLE first in __locale

Mon, Nov 9, 6:10 AM · Restricted Project
xiaoxiang781216 requested review of D91074: [libcxx] check _LIBCPP_PROVIDES_DEFAULT_RUNE_TABLE first in __locale.
Mon, Nov 9, 6:04 AM · Restricted Project
xiaoxiang781216 updated the diff for D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS.

Updating D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS

Mon, Nov 9, 4:51 AM · Restricted Project

Sun, Nov 8

xiaoxiang781216 added a comment to D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS.

@ldionne and @mclow.lists, the update should address your comment except the test and local. both of them could be addressed in the new patch.

Sun, Nov 8, 1:55 AM · Restricted Project
xiaoxiang781216 updated the diff for D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS.

Updating D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS

Sun, Nov 8, 1:44 AM · Restricted Project

Tue, Nov 3

xiaoxiang781216 added inline comments to D90072: [libc++] Add a libc++ configuration that does not support localization.
Tue, Nov 3, 2:13 AM · Restricted Project

Sun, Nov 1

xiaoxiang781216 added inline comments to D90072: [libc++] Add a libc++ configuration that does not support localization.
Sun, Nov 1, 11:52 PM · Restricted Project
xiaoxiang781216 added a comment to D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS.

Just find it here: https://reviews.llvm.org/D90072
I will change the porting to adapter the new flag, which is very important for the small embeded system.

Sun, Nov 1, 8:05 PM · Restricted Project
xiaoxiang781216 added a comment to D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS.

@ldionne could you give more info about LIBCXX_ENABLE_LOCALIZATION?

Sun, Nov 1, 8:02 PM · Restricted Project

Oct 28 2020

xiaoxiang781216 added a comment to D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS.

LIBCXX_ENABLE_LOCALIZATION is a great feature what we find it consume a large code size for small OS. Could you point me the change? I can't find LIBCXX_ENABLE_LOCALIZATION in libc++ 11.0.0 release.

Oct 28 2020, 7:55 PM · Restricted Project

Oct 2 2020

xiaoxiang781216 added a comment to D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS.

A general comment - is someone going to run a libc++ test bot for NuttX? Otherwise, how will we know when changes that we make to libc++ break NuttX support?

Oct 2 2020, 10:36 AM · Restricted Project
xiaoxiang781216 added inline comments to D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS.
Oct 2 2020, 10:22 AM · Restricted Project

Oct 1 2020

xiaoxiang781216 updated the diff for D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS.

Updating D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS

Oct 1 2020, 10:38 PM · Restricted Project
xiaoxiang781216 requested review of D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS.
Oct 1 2020, 10:33 PM · Restricted Project
xiaoxiang781216 updated xiaoxiang781216.
Oct 1 2020, 9:11 AM