Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Paths

Table of Contentst

[lldb/lua] Force Lua version to be 5.3
ClosedPublic
Actions

Authored by siger-young on Aug 21 2021, 4:59 PM.

Details

Reviewers

tammela
JDevlieghere

Commits

rG6de63b3ba5e2: [lldb/lua] Force Lua version to be 5.3
rG7bb42dc6b114: [lldb/lua] Force Lua version to be 5.3

Summary

Due to CMake cache, find_package in FindLuaAndSwig.cmake
will be ignored. This commit adds EXACT and REQUIRED flags
to it and removes find_package in Lua ScriptInterpreter.

Signed-off-by: Siger Yang <sigeryeung@gmail.com>

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

siger-young created this revision.Aug 21 2021, 4:59 PM

Herald added a subscriber: mgorny. · View Herald TranscriptAug 21 2021, 4:59 PM

siger-young requested review of this revision.Aug 21 2021, 4:59 PM

Herald added a project: Restricted Project. · View Herald TranscriptAug 21 2021, 4:59 PM

Herald added a subscriber: lldb-commits. · View Herald Transcript

Harbormaster completed remote builds in B120689: Diff 367972.Aug 21 2021, 5:33 PM

LGTM

This revision is now accepted and ready to land.Aug 23 2021, 8:43 AM

LGTM

Closed by commit rG7bb42dc6b114: [lldb/lua] Force Lua version to be 5.3 (authored by Siger Yang <sigeryeung@gmail.com>). · Explain WhySep 3 2021, 12:26 AM

This revision was automatically updated to reflect the committed changes.

Siger Yang <sigeryeung@gmail.com> added a commit: rG7bb42dc6b114: [lldb/lua] Force Lua version to be 5.3.

mstorsjo added a subscriber: mstorsjo.Sep 3 2021, 1:53 AM

mstorsjo added inline comments.

lldb/cmake/modules/FindLuaAndSwig.cmake
12	This breaks building in setups where SWIG is available, but not Lua. Previously this detected Lua and took it into use if both Lua and SWIG were available, and if not , proceeded without them.

mstorsjo added inline comments.Sep 3 2021, 2:20 AM

lldb/cmake/modules/FindLuaAndSwig.cmake
12	Just removing the `REQUIRED` from here seems to fix my build. Or I could just revert the patch to return to discussing how it should be done. I'm doing either of them fairly soon in any case, to unbreak my build.