This is an archive of the discontinued LLVM Phabricator instance.

PR46874: Reset stack after visiting a node
ClosedPublic

Authored by hiraditya on Aug 19 2021, 4:36 PM.

Details

Summary

When the stack is not reset it keeps previously visited Basic Block which results in bugs where an instruction is hoisted to a predecessor where the instruction
was not fully anticipable.

Diff Detail

Event Timeline

hiraditya requested review of this revision.Aug 19 2021, 4:36 PM
hiraditya created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2021, 4:36 PM
hiraditya updated this revision to Diff 367686.Aug 19 2021, 7:06 PM
hiraditya retitled this revision from PR46874: Reset stack after visiting a node to PR46874: Reset stack after visiting a node.

Rebase

hiraditya updated this revision to Diff 367705.Aug 19 2021, 8:50 PM

clang-format

sebpop accepted this revision.Aug 20 2021, 10:20 AM

Looks good to me.

This revision is now accepted and ready to land.Aug 20 2021, 10:20 AM
This revision was automatically updated to reflect the committed changes.