This is an archive of the discontinued LLVM Phabricator instance.

[LLDB][GUI] Add submit form key combination
ClosedPublic

Authored by OmarEmaraDev on Aug 19 2021, 2:10 PM.

Details

Summary

This patch adds a new key ALt+Enter key combination to form windows.
Once invoked, the first action is executed without having to navigate to
its button.

Field exit callbacks are now also invoked on validation to support this
aforementioned key combination.

One concern for this key combination is its potential use by the window
manager of the host. I am not sure if this will be a problem, but it is
worth putting in consideration.

Diff Detail

Event Timeline

OmarEmaraDev created this revision.Aug 19 2021, 2:10 PM
OmarEmaraDev requested review of this revision.Aug 19 2021, 2:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2021, 2:10 PM
clayborg accepted this revision.Aug 23 2021, 10:07 PM

Just tried it out. Works nicely.

This revision is now accepted and ready to land.Aug 23 2021, 10:07 PM
This revision was landed with ongoing or failed builds.Aug 23 2021, 10:07 PM
This revision was automatically updated to reflect the committed changes.