This is an archive of the discontinued LLVM Phabricator instance.

Differential D108282

[hwasan] Default -hwasan-use-stack-safety to off.
ClosedPublic

Authored by fmayer on Aug 18 2021, 2:23 AM.

Details

Reviewers
hctim
Commits
rG164e09de2e92: [hwasan] Default -hwasan-use-stack-safety to off.
Summary

This very occasionally causes to an assertion failure in the compiler.
Turning off until we can get to the bottom of this.

Diff Detail

Event Timeline

fmayer created this revision.Aug 18 2021, 2:23 AM
Herald added a subscriber: hiraditya. · View Herald TranscriptAug 18 2021, 2:23 AM
fmayer requested review of this revision.Aug 18 2021, 2:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2021, 2:23 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B120081: Diff 367152.Aug 18 2021, 3:00 AM
hctim accepted this revision.Aug 18 2021, 9:02 AM
This revision is now accepted and ready to land.Aug 18 2021, 9:02 AM
This revision was landed with ongoing or failed builds.Aug 18 2021, 9:21 AM
Closed by commit rG164e09de2e92: [hwasan] Default -hwasan-use-stack-safety to off. (authored by fmayer). · Explain Why
This revision was automatically updated to reflect the committed changes.
fmayer added a commit: rG164e09de2e92: [hwasan] Default -hwasan-use-stack-safety to off..

Revision Contents

PathSize
llvm/
lib/
Transforms/
Instrumentation/
2 lines

Diff 367233

llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp

Show First 20 Lines • Show All 109 Lines • ▼ Show 20 Lines ClRecover("hwasan-recover",
cl::desc("Enable recovery mode (continue-after-error)."), cl::desc("Enable recovery mode (continue-after-error)."),
cl::Hidden, cl::init(false)); cl::Hidden, cl::init(false));
static cl::opt<bool> ClInstrumentStack("hwasan-instrument-stack", static cl::opt<bool> ClInstrumentStack("hwasan-instrument-stack",
cl::desc("instrument stack (allocas)"), cl::desc("instrument stack (allocas)"),
cl::Hidden, cl::init(true)); cl::Hidden, cl::init(true));
static cl::opt<bool> static cl::opt<bool>
ClUseStackSafety("hwasan-use-stack-safety", cl::Hidden, cl::init(true), ClUseStackSafety("hwasan-use-stack-safety", cl::Hidden, cl::init(false),
cl::Hidden, cl::desc("Use Stack Safety analysis results"), cl::Hidden, cl::desc("Use Stack Safety analysis results"),
cl::Optional); cl::Optional);
static cl::opt<bool> static cl::opt<bool>
ClUseAfterScope("hwasan-use-after-scope", ClUseAfterScope("hwasan-use-after-scope",
cl::desc("detect use after scope within function"), cl::desc("detect use after scope within function"),
cl::Hidden, cl::init(false)); cl::Hidden, cl::init(false));
▲ Show 20 Lines • Show All 1,681 Lines • Show Last 20 Lines