This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Update and alphabetize CREDITS.TXT
ClosedPublic

Authored by mumbleskates on Aug 17 2021, 6:29 PM.

Details

Reviewers
cjdb
ldionne
Group Reviewers
Restricted Project
Commits
rG0edcd91d11d9: [libc++][NFC] Update and alphabetize CREDITS.TXT

Diff Detail

Event Timeline

mumbleskates requested review of this revision.Aug 17 2021, 6:29 PM
mumbleskates created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2021, 6:29 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
mumbleskates retitled this revision from Update and alphabetize CREDITS.TXT to [libcxx] Update and alphabetize CREDITS.TXT.Aug 17 2021, 6:32 PM
mumbleskates retitled this revision from [libcxx] Update and alphabetize CREDITS.TXT to [libc++] Update and alphabetize CREDITS.TXT.
Quuxplusone added inline comments.
libcxx/CREDITS.TXT
134–136

FWIW, I assume this name was originally alphabetized under "B" because that's the local collation order for surnames: Ruben van BOXEM; compare Klass de VRIES below. (But then Michael van der WESTHUIZEN would be wrong?)
If we're alphabetizing by surname, not just (cdr $name), then ZHANG Xiongpang remains in the wrong place.
Names are politics and politics are impossible to get right. Personally I doubt that this entire effort is helpful at all. But it's also pretty harmless, so whatever.

mumbleskates marked an inline comment as done.Aug 18 2021, 12:04 AM
mumbleskates added inline comments.
libcxx/CREDITS.TXT
134–136

Happy also to revert this specific one and fall back to the self-indication of where the surname begins (at 'B' for Ruben and at at 'v' for Michael). I don't think it's probably a huge deal as this is probably the single least important and annoying appearance of one's last name.

ldionne accepted this revision.Aug 18 2021, 6:20 AM

LGTM whichever resolution you end up picking.

This revision is now accepted and ready to land.Aug 18 2021, 6:20 AM
ldionne added inline comments.Aug 18 2021, 6:21 AM
libcxx/CREDITS.TXT
114

What does that refer to?

mumbleskates marked an inline comment as done.Aug 18 2021, 3:12 PM
mumbleskates added inline comments.
libcxx/CREDITS.TXT
114

Currently working on a bunch of diffs for operator<=> support. Do you have a more preferred wording?

This revision was automatically updated to reflect the committed changes.