This is an archive of the discontinued LLVM Phabricator instance.

Differential D108177

[compiler-rt] Add hexagon support to CFI
AcceptedPublic

Authored by bcain on Aug 16 2021, 5:56 PM.

Details

Reviewers
vitalybuka
Summary

Adds build support for hexagon linux to cfi.

Diff Detail

Event Timeline

bcain created this revision.Aug 16 2021, 5:56 PM
Herald added subscribers: s.egerton, simoncook, fedor.sergeev and 2 others. · View Herald TranscriptAug 16 2021, 5:56 PM
bcain requested review of this revision.Aug 16 2021, 5:56 PM
Herald added a subscriber: Restricted Project. · View Herald TranscriptAug 16 2021, 5:56 PM
Harbormaster completed remote builds in B119812: Diff 366776.Aug 16 2021, 5:57 PM
vitalybuka added a comment.Aug 17 2021, 10:26 AM

I'd recommend to split "cfi, safestack, profile", they are independent

compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake
29

80 chars would be nice, but it's already broken around
so up to you

bcain retitled this revision from [PATCH 7/8] [compiler-rt] Add cfi, safestack, profile to hexagon to [compiler-rt] Add cfi, safestack, profile to hexagon.Aug 17 2021, 11:13 AM
bcain updated this revision to Diff 366988.Aug 17 2021, 12:55 PM
bcain retitled this revision from [compiler-rt] Add cfi, safestack, profile to hexagon to [compiler-rt] Add hexagon support to CFI.
bcain edited the summary of this revision. (Show Details)

reduced scope to CFI only

Harbormaster completed remote builds in B119963: Diff 366988.Aug 17 2021, 12:56 PM
vitalybuka accepted this revision.Aug 17 2021, 2:22 PM
This revision is now accepted and ready to land.Aug 17 2021, 2:22 PM

Revision Contents

PathSize
compiler-rt/
cmake/
Modules/
3 lines

Diff 366988

compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake

Context not available.
set(ALL_UBSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${RISCV64} set(ALL_UBSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${RISCV64}
${MIPS32} ${MIPS64} ${PPC64} ${S390X} ${SPARC} ${SPARCV9} ${HEXAGON}) ${MIPS32} ${MIPS64} ${PPC64} ${S390X} ${SPARC} ${SPARCV9} ${HEXAGON})
set(ALL_SAFESTACK_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64} ${MIPS32} ${MIPS64}) set(ALL_SAFESTACK_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64} ${MIPS32} ${MIPS64})
set(ALL_CFI_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS64}) set(ALL_CFI_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS64}
${HEXAGON})
set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS32} set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS32}
${MIPS64} ${PPC64} ${HEXAGON}) ${MIPS64} ${PPC64} ${HEXAGON})
set(ALL_SCUDO_STANDALONE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} set(ALL_SCUDO_STANDALONE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64}
Context not available.