Disabling of "redefine_extname" pragma for C++ code

[andreybokhanko]

Summary

In response to Richard Smith's comment (http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20150622/131782.html), this patch disables "redefine_extname" pragma for C++ code. Also, I added a test that this pragma doesn't apply to static declarations.

[andreybokhanko]

Ping!

[andreybokhanko]

Patch updated in response to Aaron's comments (http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20150706/132411.html).

[andreybokhanko]

Patch updated in response to Aaron's comments (http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20150706/132552.html).

[rsmith]

Just a couple of minor things, otherwise this looks good to me.

lib/Sema/SemaDecl.cpp

5568 ↗

(On Diff #29262)

Drop the else here.

test/CodeGen/redefine_extname.c

29 ↗

(On Diff #29262)

This expected-warning does nothing, because you don't have a -verify RUN: line. This part of the test should be in test/Sema/something.

test/CodeGenCXX/redefine_extname.cpp

34 ↗

(On Diff #29262)

Likewise.

[andreybokhanko]

Fix Richard Smith's notes:

1. "else" removed form isDeclExternC
2. Two new Sema tests added: test/Sema/redefine_extname.c, test/SemaCXX/redefine_extname.cpp

[andreybokhanko]

All Richard Smith's notes are fixed.

[andreybokhanko]

Ping!

[andreybokhanko]

Added "const" specifier as recommended by Aaron (http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20150713/133400.html).

cfe/trunk/test/Sema/redefine_extname.c

+// RUN: %clang_cc1 -triple=x86_64-unknown-linux -Wpragmas -verify %s
+
+// Check that pragma redefine_extname applies to external declarations only.
+#pragma redefine_extname foo_static bar_static
+static int foo_static() { return 1; } // expected-warning {{#pragma redefine_extname is applicable to external C declarations only; not applied to function 'foo_static'}}
+