This is an archive of the discontinued LLVM Phabricator instance.

[dllexport] Instantiate default ctor default args
ClosedPublic

Authored by peterjc123 on Aug 13 2021, 2:06 AM.

Diff Detail

Event Timeline

peterjc123 requested review of this revision.Aug 13 2021, 2:06 AM
peterjc123 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2021, 2:06 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
rnk added a comment.Aug 13 2021, 8:16 AM

I think it looks good, but it needs a test.

I worry that we might have the same bug for copy closures, but the fix will be different, since those are used in exception handling.

rnk added a reviewer: hans.Aug 13 2021, 8:24 AM

I think it looks good, but it needs a test.

I worry that we might have the same bug for copy closures, but the fix will be different, since those are used in exception handling.

Thanks for your review. Since I'm pretty new to this repo, could you please tell me how to write a test here?

@rnk @hans Test added. Please take some time to review the changes.

peterjc123 updated this revision to Diff 366411.

Skip in template classes

clang-format

rnk added a comment.Aug 18 2021, 2:13 PM

Thanks for the patch and test. Can I commit this for you?

clang/lib/Sema/SemaDeclCXX.cpp
6012 ↗(On Diff #366423)

This should probably happen when explicit instantiation definitions are exported, so the TSK_ExplicitInstantiationDefinition case. However, I don't consider it a blocking issue.

Sure, please do that.

clang/lib/Sema/SemaDeclCXX.cpp
6012 ↗(On Diff #366423)

Well, I cannot constuct one code example that includes explicit instantiation definitions which triggers this problem. If you could provide one, then I may look into it.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 23 2021, 4:02 PM
This revision was automatically updated to reflect the committed changes.