This is an archive of the discontinued LLVM Phabricator instance.

[llvm-diff] add "reset" method to DiffConsumer
ClosedPublic

Authored by void on Aug 12 2021, 11:25 AM.

Details

Summary

A DiffConsumer object may be reused, but we'd like to reset it before
the next use.

No functionality change intended.

Diff Detail

Event Timeline

void requested review of this revision.Aug 12 2021, 11:25 AM
void created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2021, 11:25 AM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2021, 11:27 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.

Our buildbot seems to have failed due to an issue here.
https://lab.llvm.org/buildbot/#/builders/160/builds/3567/steps/5/logs/stdio

llvm/tools/llvm-diff/lib/DiffConsumer.cpp
138

context -> contexts?

void added a comment.Aug 12 2021, 1:26 PM

Our buildbot seems to have failed due to an issue here.
https://lab.llvm.org/buildbot/#/builders/160/builds/3567/steps/5/logs/stdio

Sorry about that. I fixed it in the follow-up patch.