This is an archive of the discontinued LLVM Phabricator instance.

[DAG] Use 'continue' to simplify EnforceNodeIdInvariant. NFC.
Needs ReviewPublic

Authored by madhur13490 on Aug 11 2021, 12:19 AM.

Reviewers

niravd
craig.topper

Summary

Reduce nesting of the loop and make the function more readble.

madhur13490 requested review of this revision.Aug 11 2021, 12:19 AM

Path

Size

llvm/

lib/

CodeGen/

SelectionDAG/

8 lines

	Show First 20 Lines • Show All 1,066 Lines • ▼ Show 20 Lines
	void SelectionDAGISel::EnforceNodeIdInvariant(SDNode *Node) {			void SelectionDAGISel::EnforceNodeIdInvariant(SDNode *Node) {
	SmallVector<SDNode *, 4> Nodes;			SmallVector<SDNode *, 4> Nodes;
	Nodes.push_back(Node);			Nodes.push_back(Node);

	while (!Nodes.empty()) {			while (!Nodes.empty()) {
	SDNode *N = Nodes.pop_back_val();			SDNode *N = Nodes.pop_back_val();
	for (auto *U : N->uses()) {			for (auto *U : N->uses()) {
	auto UId = U->getNodeId();			auto UId = U->getNodeId();
	if (UId > 0) {			if (UId <= 0)
				continue;
	InvalidateNodeId(U);			InvalidateNodeId(U);
	Nodes.push_back(U);			Nodes.push_back(U);
	}			}
	}			}
	}			}
	}

	// InvalidateNodeId - As explained in EnforceNodeIdInvariant, mark a			// InvalidateNodeId - As explained in EnforceNodeIdInvariant, mark a
	// NodeId with the equivalent node id which is invalid for topological			// NodeId with the equivalent node id which is invalid for topological
	// pruning.			// pruning.
	void SelectionDAGISel::InvalidateNodeId(SDNode *N) {			void SelectionDAGISel::InvalidateNodeId(SDNode *N) {
	int InvalidId = -(N->getNodeId() + 1);			int InvalidId = -(N->getNodeId() + 1);
	N->setNodeId(InvalidId);			N->setNodeId(InvalidId);
	}			}
	▲ Show 20 Lines • Show All 2,717 Lines • Show Last 20 Lines