This is an archive of the discontinued LLVM Phabricator instance.

[HIP] use bootstrap to build libc++
ClosedPublic

Authored by yaxunl on Aug 10 2021, 1:47 PM.

Details

Summary

Recent libc++ changes request clang-11 or gcc-11 to build.

Switch to a bootstrap build step to use built clang to build libc++.

Diff Detail

Event Timeline

yaxunl requested review of this revision.Aug 10 2021, 1:47 PM
yaxunl created this revision.
Mordante accepted this revision.Aug 11 2021, 9:40 AM

LGTM, I assume you tested the modifications locally.
I'm not sure other whether other reviewers need to sign off zorg changes, so please give them some time to respond.

zorg/buildbot/builders/annotated/hip-build.sh
87

The two comments seem a bit out of place.

This revision is now accepted and ready to land.Aug 11 2021, 9:40 AM
tra accepted this revision.Aug 11 2021, 10:02 AM
yaxunl marked an inline comment as done.Aug 11 2021, 11:59 AM
yaxunl added inline comments.
zorg/buildbot/builders/annotated/hip-build.sh
87

I will remove them.

yaxunl marked an inline comment as done.Aug 11 2021, 12:22 PM

Is there a way to test this script without committing the change? I tried running it manually but it fails due to undefined variable BUILDBOT_BUILDERNAME.

I tested the make command sequences with my local git repo and the sequence works. I will put the HIP buildbot to staging temporarily and commit my change.

This revision was automatically updated to reflect the committed changes.