This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Remove _LIBCPP_HAS_UNIQUE_OBJECT_REPRESENTATIONS
ClosedPublic

Authored by ldionne on Aug 10 2021, 8:36 AM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rG15071d294540: [libc++] Remove _LIBCPP_HAS_UNIQUE_OBJECT_REPRESENTATIONS
Summary

All supported compilers have implemented __has_unique_object_representations
for a while, so it's reasonable to remove the workaround.

Diff Detail

Event Timeline

ldionne created this revision.Aug 10 2021, 8:36 AM
ldionne requested review of this revision.Aug 10 2021, 8:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2021, 8:36 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante accepted this revision as: Mordante.Aug 10 2021, 8:54 AM

LTGM, provided the build passes. There seem to be issues with GitHub at the moment, so you probably need to restart the build at a later time.

libcxx/include/__config
548

I assume you intend to either remove this #ifdef later.

ldionne updated this revision to Diff 365521.Aug 10 2021, 9:46 AM
ldionne marked an inline comment as done.

Rebase to trigger CI

libcxx/include/__config
548

Yes, once it doesn't guard anything anymore.

ldionne accepted this revision as: Restricted Project.Aug 11 2021, 7:11 AM
This revision is now accepted and ready to land.Aug 11 2021, 7:11 AM
This revision was automatically updated to reflect the committed changes.