This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Remove Lit annotations for unsupported GCC versions from the test suite
ClosedPublic

Authored by ldionne on Aug 9 2021, 3:39 PM.

Details

Summary

Since we officially don't support several older compilers now, we can
drop a lot of the markup in the test suite. This helps keep the test
suite simple and makes sure that UNSUPPORTED annotations don't rot.

This is the first patch of a series that will remove annotations for
compilers that are now unsupported.

Diff Detail

Event Timeline

ldionne created this revision.Aug 9 2021, 3:39 PM
ldionne requested review of this revision.Aug 9 2021, 3:39 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 9 2021, 3:39 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante accepted this revision as: Mordante.Aug 9 2021, 11:23 PM
Mordante added a subscriber: Mordante.

Nice cleanup! LGTM after fixing the build issues.
Not sure you've already seen D107239, but that also removes the now obsolete _LIBCPP_HAS_NO_BUILTIN_IS_CONSTANT_EVALUATED define. (Just to avoid duplicating the same effort.)

ldionne updated this revision to Diff 365853.Aug 11 2021, 2:28 PM

Rebase onto main. That should fix the remaining issues.

ldionne accepted this revision.Aug 12 2021, 10:30 AM
This revision is now accepted and ready to land.Aug 12 2021, 10:30 AM