This is an archive of the discontinued LLVM Phabricator instance.

tsan: make all memory mappings testable
ClosedPublic

Authored by dvyukov on Aug 9 2021, 12:49 AM.

Details

Summary

Currently we define/compile the mapping for a platform
only on that platform. This makes it impossible to unit-test
them on a single platform, and even to build test.
We have 17 of them and the Go mappings will be tested
only after a manual episodic update of the Go runtime.

Define all mappings always with unique names.
This will allow to unit-test them.
No functional changes.

Diff Detail

Event Timeline

dvyukov requested review of this revision.Aug 9 2021, 12:49 AM
dvyukov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2021, 12:49 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
melver accepted this revision.Aug 9 2021, 3:24 AM
This revision is now accepted and ready to land.Aug 9 2021, 3:24 AM
dvyukov updated this revision to Diff 365235.Aug 9 2021, 11:45 AM

changed SelectMapping to use template Arg and rebased

This revision was automatically updated to reflect the committed changes.