This is an archive of the discontinued LLVM Phabricator instance.

[libc][nfc] move ctype_utils and FPUtils to __support
ClosedPublic

Authored by michaelrj on Aug 5 2021, 2:31 PM.

Details

Summary

Some ctype functions are called from other libc functions (e.g. isspace
is used in atoi). By moving ctype_utils.h to __support it becomes easier
to include just the implementations of these functions. For these
reasons the implementation for isspace was moved into
ctype_utils as well.

FPUtils was moved to simplify the build order, and to clarify which
files are a part of the actual libc.

Many files were modified to accomodate these changes, mostly changing
the #include paths.

Diff Detail

Event Timeline

michaelrj created this revision.Aug 5 2021, 2:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2021, 2:31 PM
michaelrj requested review of this revision.Aug 5 2021, 2:31 PM

The appropriate CMake files have to be updated?

michaelrj updated this revision to Diff 364638.Aug 5 2021, 3:31 PM

also move FPUtils.

michaelrj retitled this revision from [libc] move ctype_utils to __support to [libc][nfc] move ctype_utils and FPUtils to __support.Aug 5 2021, 3:31 PM
michaelrj edited the summary of this revision. (Show Details)

The cmake files have been updated, and the tests pass on my machine.

sivachandra accepted this revision.Aug 6 2021, 10:13 AM

If all the tests are passing, go for it.

This revision is now accepted and ready to land.Aug 6 2021, 10:13 AM
This revision was landed with ongoing or failed builds.Aug 6 2021, 10:29 AM
This revision was automatically updated to reflect the committed changes.