This is an archive of the discontinued LLVM Phabricator instance.

tsan: don't include tsan_interceptors.h for Go
ClosedPublic

Authored by dvyukov on Aug 5 2021, 5:44 AM.

Details

Summary

None of the interceptors machinery is used/enabled for Go,
so don't include the header, it's not needed (must not be).
The problem is that we have fields in ThreadState that are
not present in the Go build, so changes in thread_interceptors.h
can cause Go build breakages due to missing fields.

Diff Detail

Event Timeline

dvyukov requested review of this revision.Aug 5 2021, 5:44 AM
dvyukov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2021, 5:44 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
melver accepted this revision.Aug 5 2021, 6:54 AM
This revision is now accepted and ready to land.Aug 5 2021, 6:54 AM
This revision was automatically updated to reflect the committed changes.