This is an archive of the discontinued LLVM Phabricator instance.

[X86] Rename Subtarget Tuning Feature Flag Prefix. NFC.
ClosedPublic

Authored by RKSimon on Aug 4 2021, 7:02 AM.

Details

Summary

As suggested on D107370, this is a possible patch to rename the tuning feature flags to start with 'Tuning' instead of 'Feature'.

Unfortunately I'm not sure we should do this for security mitigation flags as the llvm/Support/X86TargetParser.def code uses 'llvm::X86::FEATURE_##' style stubs that include some of these flags - we're probably better off keeping the enum names as similar as possible?

Diff Detail

Event Timeline

RKSimon created this revision.Aug 4 2021, 7:02 AM
RKSimon requested review of this revision.Aug 4 2021, 7:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2021, 7:02 AM
pengfei accepted this revision.Aug 4 2021, 8:46 AM

LGTM. Thanks Simon. Quick implementation!

llvm/lib/Target/X86/X86TargetTransformInfo.h
49–50

Nit, it looks a bit strange in the middle of all TuningXXX. Maybe better to hoist to the top or give a separate comment?

This revision is now accepted and ready to land.Aug 4 2021, 8:46 AM
This revision was automatically updated to reflect the committed changes.