This is an archive of the discontinued LLVM Phabricator instance.

Differential D107446

[lldb] Stop referencing "host_lib" in cmake files
ClosedPublic

Authored by thakis on Aug 4 2021, 4:49 AM.

Details

Reviewers
teemperor
JDevlieghere
Commits
rGe71fdc1acf05: [lldb] Stop referencing "host_lib" in cmake files
Summary

lldb/tools/driver/CMakeLists.txt used to set host_lib to something until
https://reviews.llvm.org/rG7b968969db and I think CMake file processing
order means this used to be set to something in these two files here too, but
since 2.5 years ago this always expanded to nothing here. So just remove it.

No behavior change.

Diff Detail

Event Timeline

thakis created this revision.Aug 4 2021, 4:49 AM
Herald added a subscriber: mgorny. · View Herald TranscriptAug 4 2021, 4:49 AM
thakis requested review of this revision.Aug 4 2021, 4:49 AM
Harbormaster completed remote builds in B117871: Diff 364051.Aug 4 2021, 5:20 AM
teemperor accepted this revision.Aug 5 2021, 12:08 AM

lgtm, thanks!

This revision is now accepted and ready to land.Aug 5 2021, 12:08 AM
JDevlieghere accepted this revision.Aug 5 2021, 12:12 AM

Thanks!

Closed by commit rGe71fdc1acf05: [lldb] Stop referencing "host_lib" in cmake files (authored by thakis). · Explain WhyAug 5 2021, 1:19 PM
This revision was automatically updated to reflect the committed changes.
thakis added a commit: rGe71fdc1acf05: [lldb] Stop referencing "host_lib" in cmake files.

Revision Contents

PathSize
lldb/
tools/
lldb-test/
1 line
lldb-vscode/
1 line

Diff 364599

lldb/tools/lldb-test/CMakeLists.txt

Show All 12 Lines LINK_LIBS
lldbExpression lldbExpression
lldbHost lldbHost
lldbInitialization lldbInitialization
lldbInterpreter lldbInterpreter
lldbSymbol lldbSymbol
lldbTarget lldbTarget
lldbUtility lldbUtility
${LLDB_ALL_PLUGINS} ${LLDB_ALL_PLUGINS}
${host_lib}
LINK_COMPONENTS LINK_COMPONENTS
Support Support
) )
if(Python3_RPATH) if(Python3_RPATH)
set_property(TARGET lldb-test APPEND PROPERTY INSTALL_RPATH "${Python3_RPATH}") set_property(TARGET lldb-test APPEND PROPERTY INSTALL_RPATH "${Python3_RPATH}")
set_property(TARGET lldb-test APPEND PROPERTY BUILD_RPATH "${Python3_RPATH}") set_property(TARGET lldb-test APPEND PROPERTY BUILD_RPATH "${Python3_RPATH}")
endif() endif()
target_include_directories(lldb-test PRIVATE ${LLDB_SOURCE_DIR}/source) target_include_directories(lldb-test PRIVATE ${LLDB_SOURCE_DIR}/source)
target_include_directories(lldb-test PRIVATE ${LLDB_BINARY_DIR}/source) target_include_directories(lldb-test PRIVATE ${LLDB_BINARY_DIR}/source)

lldb/tools/lldb-vscode/CMakeLists.txt

Show All 34 Linesadd_lldb_tool(lldb-vscode
OutputRedirector.cpp OutputRedirector.cpp
ProgressEvent.cpp ProgressEvent.cpp
RunInTerminal.cpp RunInTerminal.cpp
SourceBreakpoint.cpp SourceBreakpoint.cpp
VSCode.cpp VSCode.cpp
LINK_LIBS LINK_LIBS
liblldb liblldb
${host_lib}
${extra_libs} ${extra_libs}
LINK_COMPONENTS LINK_COMPONENTS
Option Option
Support Support
) )
if(LLDB_BUILD_FRAMEWORK) if(LLDB_BUILD_FRAMEWORK)
Show All 11 Lines