So that building the compiler-rt target also copies the cfi ignorelist
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
not sure what the proper way to do this is
if I remove ($host_toolchain) I get
ninja: warning: multiple rules generate lib/clang/14.0.0/share/cfi_ignorelist.txt. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn]
llvm/utils/gn/secondary/compiler-rt/lib/BUILD.gn | ||
---|---|---|
3 | This works. Another approach is to have an if (current_toolchain == default_toolchain) around the cfi:ignorelist target. (But this is fine too.) This dep is supposed to already be added here though: https://github.com/llvm/llvm-project/blob/main/llvm/utils/gn/secondary/compiler-rt/test/hwasan/BUILD.gn#L38 Does that not work? Or do you want it be built as part of some specific target that doesn't include it yet? |
llvm/utils/gn/secondary/compiler-rt/lib/BUILD.gn | ||
---|---|---|
3 | (In other words, answer "Why?" in the commit description.) |
This works. Another approach is to have an if (current_toolchain == default_toolchain) around the cfi:ignorelist target. (But this is fine too.)
This dep is supposed to already be added here though: https://github.com/llvm/llvm-project/blob/main/llvm/utils/gn/secondary/compiler-rt/test/hwasan/BUILD.gn#L38
Does that not work? Or do you want it be built as part of some specific target that doesn't include it yet?