[Polly][Isl] Use isl::val::sub instead of isl::val::sub_ui. NFC

[patacca]

Summary

This is part of an effort to reduce the differences between the custom C++ bindings used right now by polly in lib/External/isl/include/isl/isl-noxceptions.h and the official isl C++ interface.

Changes made:

• Use isl::val::sub instead of isl::val::sub_ui
• isl-noexceptions.h has been generated by https://github.com/patacca/isl/commit/355e84163ae78ff637c71fb532f36d15277a2b1b

Depends on D107225

[Meinersbur]

LGTM

[patacca]

Rebase to main

polly/lib/Analysis/ScopInfo.cpp

static isl::set addRangeBoundsToSet(isl::set S, const ConstantRange &Range,
 
   // In case of signed wrapping, we can refine the set of valid values by
   // excluding the part not covered by the wrapping range.
   if (Range.isSignWrappedSet()) {
     V = valFromAPInt(Ctx.get(), Range.getLower(), true);
     isl::set SLB = S.lower_bound_val(type, dim, V);
 
     V = valFromAPInt(Ctx.get(), Range.getUpper(), true);
-    V = V.sub_ui(1);
+    V = V.sub(1);
     isl::set SUB = S.upper_bound_val(type, dim, V);
     S = SLB.unite(SUB);
   }
 
   return S;
 }
 
 static const ScopArrayInfo *identifyBasePtrOriginSAI(Scop *S, Value *BasePtr) {

polly/lib/External/isl/include/isl/isl-noexceptions.h

public:
   static inline isl::val negone(isl::ctx ctx);
   inline long num_si() const;
   inline long get_num_si() const;
   static inline isl::val one(isl::ctx ctx);
   inline isl::val pow2() const;
   inline int sgn() const;
   inline isl::val sub(isl::val v2) const;
   inline isl::val sub(long v2) const;
-  inline isl::val sub_ui(unsigned long v2) const;
   inline isl::val_list to_list() const;
   inline isl::val trunc() const;
   static inline isl::val zero(isl::ctx ctx);
 };
 
 // declarations for isl::val_list
 inline val_list manage(__isl_take isl_val_list *ptr);
 inline val_list manage_copy(__isl_keep isl_val_list *ptr);
isl::val val::sub(isl::val v2) const
   return manage(res);
 }
 
 isl::val val::sub(long v2) const
 {
   return this->sub(isl::val(ctx(), v2));
 }
 
-isl::val val::sub_ui(unsigned long v2) const
-{
-  auto res = isl_val_sub_ui(copy(), v2);
-  return manage(res);
-}
-
 isl::val_list val::to_list() const
 {
   auto res = isl_val_to_list(copy());
   return manage(res);
 }
 
 isl::val val::trunc() const
 {

polly/unittests/Isl/IslTest.cpp

isl_ctx *IslCtx = isl_ctx_alloc();
     APInt APTwo(32, 2, false);
     auto IslTwo = valFromAPInt(IslCtx, APTwo, false);
     EXPECT_EQ(0, IslTwo.cmp_si(2));
   }
 
   {
     APInt APNOne(32, (1ull << 32) - 1, false);
     auto IslNOne = valFromAPInt(IslCtx, APNOne, false);
-    auto IslRef = isl::val(IslCtx, 32).pow2().sub_ui(1);
+    auto IslRef = isl::val(IslCtx, 32).pow2().sub(1);
     EXPECT_EQ(IslNOne, IslRef);
   }
 
   {
     APInt APLarge(130, 2, false);
     APLarge = APLarge.shl(70);
     auto IslLarge = valFromAPInt(IslCtx, APLarge, false);
     auto IslRef = isl::val(IslCtx, 71);
TEST(Isl, IslValToAPInt) {
   {
     auto IslFour = isl::val(IslCtx, 4);
     auto APFour = APIntFromVal(IslFour);
     EXPECT_EQ(4, APFour);
     EXPECT_EQ(4u, APFour.getBitWidth());
   }
 
   {
-    auto IslNOne = isl::val(IslCtx, 32).pow2().sub_ui(1);
+    auto IslNOne = isl::val(IslCtx, 32).pow2().sub(1);
     auto APNOne = APIntFromVal(IslNOne);
     EXPECT_EQ((1ull << 32) - 1, APNOne);
     EXPECT_EQ(33u, APNOne.getBitWidth());
   }
 
   {
     auto IslLargeNum = isl::val(IslCtx, 60);
     IslLargeNum = IslLargeNum.pow2();
-    IslLargeNum = IslLargeNum.sub_ui(1);
+    IslLargeNum = IslLargeNum.sub(1);
     auto APLargeNum = APIntFromVal(IslLargeNum);
     EXPECT_EQ((1ull << 60) - 1, APLargeNum);
     EXPECT_EQ(61u, APLargeNum.getBitWidth());
   }
 
   {
     auto IslExp = isl::val(IslCtx, 500);
     auto IslLargePow2 = IslExp.pow2();