This is an archive of the discontinued LLVM Phabricator instance.

compiler-rt/lib/tsan/rtl/tsan_sync.cpp
198–199	Would restricting scope of idx and moving condition into loop-condition be more readable? for (u32 idx = idx0; LIKELY((idx != 0) && !(idx & kFlagBlock));) {

This revision is now accepted and ready to land.Aug 2 2021, 3:41 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

compiler-rt/

lib/

tsan/

rtl/

13 lines

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Lines	for (;;) {
idx = s->next;		idx = s->next;
}		}
}		}

SyncVar MetaMap::GetSync(ThreadState thr, uptr pc, uptr addr, bool create) {		SyncVar MetaMap::GetSync(ThreadState thr, uptr pc, uptr addr, bool create) {
u32 *meta = MemToMeta(addr);		u32 *meta = MemToMeta(addr);
u32 idx0 = *meta;		u32 idx0 = *meta;
u32 myidx = 0;		u32 myidx = 0;
SyncVar *mys = 0;		SyncVar *mys = nullptr;
for (;;) {		for (;;) {
u32 idx = idx0;		for (u32 idx = idx0; idx && !(idx & kFlagBlock);) {
		melverUnsubmitted Not Done Reply Inline Actions Would restricting scope of idx and moving condition into loop-condition be more readable? for (u32 idx = idx0; LIKELY((idx != 0) && !(idx & kFlagBlock));) { melver: Would restricting scope of idx and moving condition into loop-condition be more readable? ```…
for (;;) {
if (idx == 0)
break;
if (idx & kFlagBlock)
break;
DCHECK(idx & kFlagSync);		DCHECK(idx & kFlagSync);
SyncVar * s = sync_alloc_.Map(idx & ~kFlagMask);		SyncVar * s = sync_alloc_.Map(idx & ~kFlagMask);
if (s->addr == addr) {		if (LIKELY(s->addr == addr)) {
if (myidx != 0) {		if (UNLIKELY(myidx != 0)) {
mys->Reset(thr->proc());		mys->Reset(thr->proc());
sync_alloc_.Free(&thr->proc()->sync_cache, myidx);		sync_alloc_.Free(&thr->proc()->sync_cache, myidx);
}		}
return s;		return s;
}		}
idx = s->next;		idx = s->next;
}		}
if (!create)		if (!create)
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines