This is an archive of the discontinued LLVM Phabricator instance.

tsan: minor IgnoreSet refactoring
ClosedPublic

Authored by dvyukov on Jul 31 2021, 12:56 AM.

Details

Summary
  1. Move kMaxSize declaration to private section.
  2. Inline Reset, it's trivial and called semi-frequently.

Diff Detail

Event Timeline

dvyukov requested review of this revision.Jul 31 2021, 12:56 AM
dvyukov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2021, 12:56 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
melver accepted this revision.Aug 2 2021, 1:30 AM
melver added inline comments.
compiler-rt/lib/tsan/rtl/tsan_ignoreset.cpp
31–32

Could make this inlinable too?
Would save generation of IgnoreSet::Size() function even if called infrequently.

This revision is now accepted and ready to land.Aug 2 2021, 1:30 AM
dvyukov updated this revision to Diff 363410.Aug 2 2021, 2:11 AM

inline Size

dvyukov marked an inline comment as done.Aug 2 2021, 2:11 AM
This revision was landed with ongoing or failed builds.Aug 2 2021, 2:13 AM
This revision was automatically updated to reflect the committed changes.