This is an archive of the discontinued LLVM Phabricator instance.

Differential D107172

Revert "[libcxx][CI] Work around Arm buildkite failures"
ClosedPublic

Authored by DavidSpickett on Jul 30 2021, 8:37 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rGe517a2405f39: Revert "[libcxx][CI] Work around Arm buildkite failures"
Summary

This reverts commit f8bef4734845226c079900de3c273c8ab1915b49.

Buildkite agent 3.32.0 includes a fix for the PATH issue.
https://github.com/buildkite/agent/releases/tag/v3.32.0

Diff Detail

Event Timeline

DavidSpickett created this revision.Jul 30 2021, 8:37 AM
Herald added subscribers: kristof.beyls, arichardson. · View Herald TranscriptJul 30 2021, 8:37 AM
DavidSpickett requested review of this revision.Jul 30 2021, 8:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2021, 8:37 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B117196: Diff 363107.Jul 30 2021, 9:50 AM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 2 2021, 1:32 AM
Closed by commit rGe517a2405f39: Revert "[libcxx][CI] Work around Arm buildkite failures" (authored by DavidSpickett). · Explain Why
This revision was automatically updated to reflect the committed changes.
DavidSpickett added a commit: rGe517a2405f39: Revert "[libcxx][CI] Work around Arm buildkite failures".
DavidSpickett added a comment.Aug 2 2021, 1:33 AM

Landing without review since it's a simple revert and the pre-commit build was fine.

Revision Contents

PathSize
libcxx/
utils/
ci/
12 lines

Diff 363395

libcxx/utils/ci/run-buildbot

Show First 20 Lines • Show All 474 Lines • ▼ Show 20 Lineslegacy-standalone)
echo "+++ Running the libc++ tests" echo "+++ Running the libc++ tests"
${NINJA} -vC "${BUILD_DIR}/libcxx" check-cxx ${NINJA} -vC "${BUILD_DIR}/libcxx" check-cxx
echo "+++ Running the libc++abi tests" echo "+++ Running the libc++abi tests"
${NINJA} -vC "${BUILD_DIR}/libcxxabi" check-cxxabi ${NINJA} -vC "${BUILD_DIR}/libcxxabi" check-cxxabi
;; ;;
aarch64) aarch64)
export CC=/usr/local/bin/cc
export CXX=/usr/local/bin/c++
clean clean
generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/AArch64.cmake" generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/AArch64.cmake"
check-cxx-cxxabi check-cxx-cxxabi
;; ;;
aarch64-noexceptions) aarch64-noexceptions)
export CC=/usr/local/bin/cc
export CXX=/usr/local/bin/c++
clean clean
generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/AArch64.cmake" \ generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/AArch64.cmake" \
-DLIBCXX_ENABLE_EXCEPTIONS=OFF \ -DLIBCXX_ENABLE_EXCEPTIONS=OFF \
-DLIBCXXABI_ENABLE_EXCEPTIONS=OFF -DLIBCXXABI_ENABLE_EXCEPTIONS=OFF
check-cxx-cxxabi check-cxx-cxxabi
;; ;;
# Aka Armv8 32 bit # Aka Armv8 32 bit
armv8) armv8)
export CC=/usr/local/bin/cc
export CXX=/usr/local/bin/c++
clean clean
generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv8Arm.cmake" generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv8Arm.cmake"
check-cxx-cxxabi check-cxx-cxxabi
;; ;;
armv8-noexceptions) armv8-noexceptions)
export CC=/usr/local/bin/cc
export CXX=/usr/local/bin/c++
clean clean
generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv8Thumb-noexceptions.cmake" generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv8Thumb-noexceptions.cmake"
check-cxx-cxxabi check-cxx-cxxabi
;; ;;
# Armv7 32 bit. One building Arm only one Thumb only code. # Armv7 32 bit. One building Arm only one Thumb only code.
armv7) armv7)
export CC=/usr/local/bin/cc
export CXX=/usr/local/bin/c++
clean clean
generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv7Arm.cmake" generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv7Arm.cmake"
check-cxx-cxxabi check-cxx-cxxabi
;; ;;
armv7-noexceptions) armv7-noexceptions)
export CC=/usr/local/bin/cc
export CXX=/usr/local/bin/c++
clean clean
generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv7Thumb-noexceptions.cmake" generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv7Thumb-noexceptions.cmake"
check-cxx-cxxabi check-cxx-cxxabi
;; ;;
windows-dll) windows-dll)
clean clean
# TODO: Currently, building with the experimental library breaks running # TODO: Currently, building with the experimental library breaks running
# tests (the test linking look for the c++experimental library with the # tests (the test linking look for the c++experimental library with the
Show All 27 Lines