This is an archive of the discontinued LLVM Phabricator instance.

Differential D107168

sanitizers: build tests with -g
ClosedPublic

Authored by dvyukov on Jul 30 2021, 7:58 AM.

Details

Reviewers
vitalybuka
melver
Commits
rG3ea3b6b2d411: sanitizers: build tests with -g
Summary

We currently build tests without -g, which is quite inconvenient.
Crash stacks don't have line numbers, gdb don't how line numbers either.
Always build tests with -g.

Diff Detail

Event Timeline

dvyukov created this revision.Jul 30 2021, 7:58 AM
Herald added a subscriber: mgorny. · View Herald TranscriptJul 30 2021, 7:58 AM
dvyukov requested review of this revision.Jul 30 2021, 7:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2021, 7:58 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B117187: Diff 363094.Jul 30 2021, 8:30 AM
vitalybuka accepted this revision.Jul 30 2021, 11:24 AM
This revision is now accepted and ready to land.Jul 30 2021, 11:24 AM
Closed by commit rG3ea3b6b2d411: sanitizers: build tests with -g (authored by dvyukov). · Explain WhyJul 30 2021, 11:55 PM
This revision was automatically updated to reflect the committed changes.
dvyukov added a commit: rG3ea3b6b2d411: sanitizers: build tests with -g.

Revision Contents

PathSize
compiler-rt/
3 lines

Diff 363270

compiler-rt/CMakeLists.txt

Show First 20 Lines • Show All 542 Lines • ▼ Show 20 Lines
set(COMPILER_RT_GMOCK_SOURCE ${COMPILER_RT_GMOCK_PATH}/src/gmock-all.cc) set(COMPILER_RT_GMOCK_SOURCE ${COMPILER_RT_GMOCK_PATH}/src/gmock-all.cc)
set(COMPILER_RT_GMOCK_CFLAGS set(COMPILER_RT_GMOCK_CFLAGS
-DGTEST_NO_LLVM_SUPPORT=1 -DGTEST_NO_LLVM_SUPPORT=1
-DGTEST_HAS_RTTI=0 -DGTEST_HAS_RTTI=0
-I${COMPILER_RT_GMOCK_PATH}/include -I${COMPILER_RT_GMOCK_PATH}/include
-I${COMPILER_RT_GMOCK_PATH} -I${COMPILER_RT_GMOCK_PATH}
) )
if(COMPILER_RT_HAS_G_FLAG)
list(APPEND COMPILER_RT_UNITTEST_CFLAGS -g)
endif()
append_list_if(COMPILER_RT_DEBUG -DSANITIZER_DEBUG=1 COMPILER_RT_UNITTEST_CFLAGS) append_list_if(COMPILER_RT_DEBUG -DSANITIZER_DEBUG=1 COMPILER_RT_UNITTEST_CFLAGS)
append_list_if(COMPILER_RT_HAS_WCOVERED_SWITCH_DEFAULT_FLAG -Wno-covered-switch-default COMPILER_RT_UNITTEST_CFLAGS) append_list_if(COMPILER_RT_HAS_WCOVERED_SWITCH_DEFAULT_FLAG -Wno-covered-switch-default COMPILER_RT_UNITTEST_CFLAGS)
append_list_if(COMPILER_RT_HAS_WSUGGEST_OVERRIDE_FLAG -Wno-suggest-override COMPILER_RT_UNITTEST_CFLAGS) append_list_if(COMPILER_RT_HAS_WSUGGEST_OVERRIDE_FLAG -Wno-suggest-override COMPILER_RT_UNITTEST_CFLAGS)
if(MSVC) if(MSVC)
# gtest use a lot of stuff marked as deprecated on Windows. # gtest use a lot of stuff marked as deprecated on Windows.
list(APPEND COMPILER_RT_GTEST_CFLAGS -Wno-deprecated-declarations) list(APPEND COMPILER_RT_GTEST_CFLAGS -Wno-deprecated-declarations)
endif() endif()
▲ Show 20 Lines • Show All 99 Lines • Show Last 20 Lines