Page MenuHomePhabricator

[libc] Move FPExceptMatcher out of TestHelpers.h
ClosedPublic

Authored by sivachandra on Jul 29 2021, 10:33 PM.

Details

Summary

TestHelpers.h pulls few pieces from LLVM libc's unittest framework
which aren't available on platforms like Fuchsia which use their own
unittest framework. So, by moving FPExceptMatcher to a different file
we can exclude LLVM libc specific pieces in a cleaner way.

In a later pass, it might make more sense to rename TestHelpers.h also
to FPMatcher.h. That way, we can make macros like EXPECT_FP_EQ to be
equivalent to EXPECT_EQ on platforms like Fuchsia.

Diff Detail

Event Timeline

sivachandra created this revision.Jul 29 2021, 10:33 PM
sivachandra requested review of this revision.Jul 29 2021, 10:33 PM
This revision is now accepted and ready to land.Jul 30 2021, 11:33 AM
This revision was landed with ongoing or failed builds.Jul 30 2021, 4:44 PM
This revision was automatically updated to reflect the committed changes.