This is an archive of the discontinued LLVM Phabricator instance.

sanitizer_common: avoid compiler-interted memset in deadlock detector
ClosedPublic

Authored by dvyukov on Jul 28 2021, 11:04 AM.

Details

Summary

Compilers tends to insert memset/memcpy for some struct/array operations,
and these don't play well inside of sanitizer runtimes.
Avoiding these calls was the intention behind internal_memset.
Remove the leftover ={} that can result in memset call.

Diff Detail

Event Timeline

dvyukov requested review of this revision.Jul 28 2021, 11:04 AM
dvyukov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2021, 11:04 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
pgousseau accepted this revision.Jul 28 2021, 11:13 AM

Lgtm! Thank you for the quick fix!

This revision is now accepted and ready to land.Jul 28 2021, 11:13 AM
vitalybuka accepted this revision.Jul 28 2021, 11:17 AM
This revision was landed with ongoing or failed builds.Jul 28 2021, 11:27 AM
This revision was automatically updated to reflect the committed changes.