Page MenuHomePhabricator

Fixing an infinite loop problem in InstCombine
ClosedPublic

Authored by mfawaz on Jul 28 2021, 5:45 AM.

Details

Summary

This issues started happening after
https://github.com/llvm/llvm-project/commit/b373b5990d5991a920c421b21a352e4ccf4c4993
Basically, if the memcpy is volatile, the collectUsers() function should
return false, just like we do for volatile loads.

Diff Detail

Event Timeline

mfawaz created this revision.Jul 28 2021, 5:45 AM
mfawaz requested review of this revision.Jul 28 2021, 5:45 AM

LGTM. Thanks !

This change should also go on the 13.x branch.

This revision is now accepted and ready to land.Jul 28 2021, 6:11 AM
This revision was automatically updated to reflect the committed changes.