This is an archive of the discontinued LLVM Phabricator instance.

Differential D106718

[libc] add scudo wrappers to llvm libc
ClosedPublic

Authored by michaelrj on Jul 23 2021, 3:17 PM.

Details

Reviewers
sivachandra
Commits
rG016ae7df95f2: [libc] add scudo wrappers to llvm libc
Summary

The previous patch included the implementations for the scudo allocator,
but not the wrappers. This change fixes that.

Diff Detail

Event Timeline

michaelrj created this revision.Jul 23 2021, 3:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 23 2021, 3:17 PM
Herald added subscribers: libc-commits, ecnelises, tschuett and 2 others. · View Herald Transcript
michaelrj requested review of this revision.Jul 23 2021, 3:17 PM
sivachandra accepted this revision.Jul 23 2021, 3:22 PM
sivachandra added inline comments.
libc/lib/CMakeLists.txt
5

Nit:
You don't need another call to list(APPEND ...). You add the new library to the previous list(APPEND ...) call.
Also, may be call the var SCUDO_DEPS (in plural).

This revision is now accepted and ready to land.Jul 23 2021, 3:22 PM
Harbormaster completed remote builds in B115962: Diff 361363.Jul 23 2021, 3:54 PM
michaelrj updated this revision to Diff 361715.Jul 26 2021, 10:23 AM
michaelrj marked an inline comment as done.

address comments

This revision was landed with ongoing or failed builds.Jul 26 2021, 10:25 AM
Closed by commit rG016ae7df95f2: [libc] add scudo wrappers to llvm libc (authored by michaelrj). · Explain Why
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rG016ae7df95f2: [libc] add scudo wrappers to llvm libc.
Harbormaster completed remote builds in B116217: Diff 361715.Jul 26 2021, 11:21 AM

Revision Contents

PathSize
libc/
lib/
1 line

Diff 361363

libc/lib/CMakeLists.txt

set(SCUDO_DEP "") set(SCUDO_DEP "")
if(LLVM_LIBC_INCLUDE_SCUDO) if(LLVM_LIBC_INCLUDE_SCUDO)
list(APPEND SCUDO_DEP RTScudoStandalone.${LIBC_TARGET_ARCHITECTURE}) list(APPEND SCUDO_DEP RTScudoStandalone.${LIBC_TARGET_ARCHITECTURE})
list(APPEND SCUDO_DEP RTScudoStandaloneCWrappers.${LIBC_TARGET_ARCHITECTURE})
sivachandraUnsubmitted
Done
ReplyInline Actions

Nit:
You don't need another call to list(APPEND ...). You add the new library to the previous list(APPEND ...) call.
Also, may be call the var SCUDO_DEPS (in plural).

sivachandra: Nit: You don't need another call to `list(APPEND ...)`. You add the new library to the previous…
endif() endif()
add_entrypoint_library( add_entrypoint_library(
llvmlibc llvmlibc
DEPENDS DEPENDS
${TARGET_LLVMLIBC_ENTRYPOINTS} ${TARGET_LLVMLIBC_ENTRYPOINTS}
EXT_DEPS EXT_DEPS
${SCUDO_DEP} ${SCUDO_DEP}
Show All 20 Lines