This is an archive of the discontinued LLVM Phabricator instance.

[libc] Clean up Windows macros
ClosedPublic

Authored by caitlyncano on Jul 23 2021, 1:43 PM.

Details

Summary

This clean-up removes checks for _WIN64, as the _WIN32 macro returns 1
whenever the compilation targe is 32- or 64-bit ARM, as well as x86 and x64
(see Windows pre-defined macro documentation
https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros).

Diff Detail

Event Timeline

caitlyncano created this revision.Jul 23 2021, 1:43 PM
caitlyncano requested review of this revision.Jul 23 2021, 1:43 PM

not just ARM but also x86/x64 (which is what we're working with)

maybe a reference to https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros in the description would be good

libc/utils/UnitTest/PlatformDefs.h
12

extra parentheses

caitlyncano marked an inline comment as done.Jul 23 2021, 1:50 PM

[libc] Remove extra parentheses and reference documentation

aeubanks accepted this revision.Jul 23 2021, 2:08 PM

lg after updating the description

This revision is now accepted and ready to land.Jul 23 2021, 2:08 PM
This revision was landed with ongoing or failed builds.Jul 23 2021, 2:12 PM
This revision was automatically updated to reflect the committed changes.
caitlyncano edited the summary of this revision. (Show Details)Jul 23 2021, 2:16 PM
caitlyncano edited the summary of this revision. (Show Details)Jul 23 2021, 2:18 PM