[LLDB][GUI] Check fields validity in actions

[OmarEmaraDev]

Summary

This patch adds a virtual method HasError to fields, it can be
overridden by fields that have errors. Additionally, a form method
CheckFieldsValidity was added to be called by actions that expects all
the field to be valid.

[OmarEmaraDev]

• Merge main and fix conflicts.

lldb/source/Core/IOHandlerCursesGUI.cpp

public:
   virtual bool FieldDelegateOnLastOrOnlyElement() { return true; }
 
   // Select the first element in the field if multiple elements exists.
   virtual void FieldDelegateSelectFirstElement() { return; }
 
   // Select the last element in the field if multiple elements exists.
   virtual void FieldDelegateSelectLastElement() { return; }
 
+  // Returns true if the field has an error, false otherwise.
+  virtual bool FieldDelegateHasError() { return false; }
+
   bool FieldDelegateIsVisible() { return m_is_visible; }
 
   void FieldDelegateHide() { m_is_visible = false; }
 
   void FieldDelegateShow() { m_is_visible = true; }
 
 protected:
   bool m_is_visible = true;
public:
   // The text field has a height of 3 lines. 2 lines for borders and 1 line for
   // the content.
   int GetFieldHeight() { return 3; }
 
   // The text field has a full height of 3 or 4 lines. 3 lines for the actual
   // field and an optional line for an error if it exists.
   int FieldDelegateGetHeight() override {
     int height = GetFieldHeight();
-    if (HasError())
+    if (FieldDelegateHasError())
       height++;
     return height;
   }
 
   // Get the cursor X position in the surface coordinate.
   int GetCursorXPosition() { return m_cursor_position - m_first_visibile_char; }
 
   int GetContentLength() { return m_content.length(); }
void DrawField(SubPad &surface, bool is_selected) {
     Rect content_bounds = surface.GetFrame();
     content_bounds.Inset(1, 1);
     SubPad content_surface = SubPad(surface, content_bounds);
 
     DrawContent(content_surface, is_selected);
   }
 
   void DrawError(SubPad &surface) {
-    if (!HasError())
+    if (!FieldDelegateHasError())
       return;
     surface.MoveCursor(0, 0);
     surface.AttributeOn(COLOR_PAIR(RedOnBlack));
     surface.PutChar(ACS_DIAMOND);
     surface.PutChar(' ');
     surface.PutCStringTruncated(1, GetError().c_str());
     surface.AttributeOff(COLOR_PAIR(RedOnBlack));
   }
case KEY_BACKSPACE:
       RemoveChar();
       return eKeyHandled;
     default:
       break;
     }
     return eKeyNotHandled;
   }
 
+  bool FieldDelegateHasError() override { return !m_error.empty(); }
+
   void FieldDelegateExitCallback() override {
     if (!IsSpecified() && m_required)
       SetError("This field is required!");
   }
 
   bool IsSpecified() { return !m_content.empty(); }
 
-  bool HasError() { return !m_error.empty(); }
-
   void ClearError() { m_error.clear(); }
 
   const std::string &GetError() { return m_error; }
 
   void SetError(const char *error) { m_error = error; }
 
   const std::string &GetText() { return m_content; }
 
public:
   bool HasError() { return !m_error.empty(); }
 
   void ClearError() { m_error.clear(); }
 
   const std::string &GetError() { return m_error; }
 
   void SetError(const char *error) { m_error = error; }
 
+  // If all fields are valid, true is returned. Otherwise, an error message is
+  // set and false is returned. This method is usually called at the start of an
+  // action that requires valid fields.
+  bool CheckFieldsValidity() {
+    for (int i = 0; i < GetNumberOfFields(); i++) {
+      if (GetField(i)->FieldDelegateHasError()) {
+        SetError("Some fields are invalid!");
+        return false;
+      }
+    }
+    return true;
+  }
+
   // Factory methods to create and add fields of specific types.
 
   TextFieldDelegate *AddTextField(const char *label, const char *content,
                                   bool required) {
     TextFieldDelegate *delegate =
         new TextFieldDelegate(label, content, required);
     m_fields.push_back(FieldDelegateUP(delegate));
     return delegate;
ProcessAttachInfo GetAttachInfo() {
     attach_info.SetProcessPluginName(m_plugin_field->GetPluginName());
 
     return attach_info;
   }
 
   void Attach(Window &window) {
     ClearError();
 
+    bool all_fields_are_valid = CheckFieldsValidity();
+    if (!all_fields_are_valid)
+      return;
+
     bool process_is_running = StopRunningProcess();
     if (process_is_running)
       return;
 
     Target *target = GetTarget();
     if (HasError())
       return;