This is an archive of the discontinued LLVM Phabricator instance.

sanitizer_common: revert StaticSpinMutex ctor
ClosedPublic

Authored by dvyukov on Jul 21 2021, 12:13 AM.

Details

Summary

Patch "sanitizer_common: modernize SpinMutex" added default
ctor to StaticSpinMutex. But it broke some gcc bots with:

scudo_tsd_exclusive.cpp:25:22: error: non-local variable
scudo::TSD’ declared ‘thread’ needs dynamic initialization

https://lab.llvm.org/buildbot/#/builders/105/builds/12649

Unfortunatly none of empty ctor {}, no ctor, default constexpr ctor
work for different reasons. So remove StaticSpinMutex ctor
entirely and move deleted copy ctor back to SpinMutex.

Diff Detail

Event Timeline

dvyukov created this revision.Jul 21 2021, 12:13 AM
dvyukov requested review of this revision.Jul 21 2021, 12:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 21 2021, 12:13 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 12:22 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.