This is an archive of the discontinued LLVM Phabricator instance.

Differential D106391

[libc] Append math functions to Window's entrypoints
ClosedPublic

Authored by hedingarcia on Jul 20 2021, 1:10 PM.

Details

Reviewers
sivachandra
aeubanks
Commits
rGf49f2e2d1f8d: [libc] Append math functions to Window's entrypoints

Diff Detail

Event Timeline

hedingarcia created this revision.Jul 20 2021, 1:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2021, 1:10 PM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
hedingarcia requested review of this revision.Jul 20 2021, 1:10 PM
Harbormaster completed remote builds in B115173: Diff 360249.Jul 20 2021, 2:36 PM
sivachandra accepted this revision.Jul 21 2021, 1:21 AM
sivachandra added inline comments.
libc/config/windows/entrypoints.txt
43

Not sure if libm makes sense on Windows. May be you can put all of these functions and the string functions under TARGET_LLVMLIBC_ENTRYPOINTS on line 71. We can revisit if required. OK for now.

This revision is now accepted and ready to land.Jul 21 2021, 1:21 AM
Closed by commit rGf49f2e2d1f8d: [libc] Append math functions to Window's entrypoints (authored by hedingarcia). · Explain WhyJul 21 2021, 6:22 AM
This revision was automatically updated to reflect the committed changes.
hedingarcia added a commit: rGf49f2e2d1f8d: [libc] Append math functions to Window's entrypoints.

Revision Contents

PathSize
libc/
config/
windows/
30 lines

Diff 360415

libc/config/windows/entrypoints.txt

Show All 33 Linesset(TARGET_LIBC_ENTRYPOINTS
libc.src.string.strnlen libc.src.string.strnlen
libc.src.string.strpbrk libc.src.string.strpbrk
libc.src.string.strrchr libc.src.string.strrchr
libc.src.string.strspn libc.src.string.strspn
libc.src.string.strstr libc.src.string.strstr
libc.src.string.strtok libc.src.string.strtok
libc.src.string.strtok_r libc.src.string.strtok_r
) )
set(TARGET_LIBM_ENTRYPOINTS
sivachandraUnsubmitted
Not Done
ReplyInline Actions

Not sure if libm makes sense on Windows. May be you can put all of these functions and the string functions under TARGET_LLVMLIBC_ENTRYPOINTS on line 71. We can revisit if required. OK for now.

sivachandra: Not sure if libm makes sense on Windows. May be you can put all of these functions and the…
# math.h entrypoints
libc.src.math.copysign
libc.src.math.copysignf
libc.src.math.copysignl
libc.src.math.fdimf
libc.src.math.fdim
libc.src.math.fdiml
libc.src.math.fmin
libc.src.math.fminf
libc.src.math.fminl
libc.src.math.fmax
libc.src.math.fmaxf
libc.src.math.fmaxl
libc.src.math.ilogb
libc.src.math.ilogbf
libc.src.math.ilogbl
libc.src.math.ldexp
libc.src.math.ldexpf
libc.src.math.ldexpl
libc.src.math.logb
libc.src.math.logbf
libc.src.math.logbl
libc.src.math.modf
libc.src.math.modff
libc.src.math.modfl
)
set(TARGET_LLVMLIBC_ENTRYPOINTS set(TARGET_LLVMLIBC_ENTRYPOINTS
${TARGET_LIBC_ENTRYPOINTS} ${TARGET_LIBC_ENTRYPOINTS}
${TARGET_LIBM_ENTRYPOINTS}
) )