[CSSPGO] Turn on unique linkage name by default for pseudo probe.

[hoy]

Summary

Turning on -funique-internal-linkage-names when -fpseudo-probe-for-profiling is on, unless -fno-unique-internal-linkage-names is specified.

[wenlei]

clang/test/Driver/pseudo-probe.c

4

how do we test unique linkage name is implied with probe on?

[hoy]

clang/test/Driver/pseudo-probe.c

4

These two test lines below corresponding to line 1 in the test, which show that -funique-internal-linkage-names is passed to cc1.

// YESPROBE: -fpseudo-probe-for-profiling
// YESPROBE: -funique-internal-linkage-names

The change being made here is a driver change, so a driver test should be good.

[wenlei]

clang/test/Driver/pseudo-probe.c

4

The change is about making -funique-internal-linkage-names implied, but the test specified that switch explicitly. I was asking how to test the "implicit" part? Not sure what line 4 is testing wrt to this change.

[hoy]

clang/test/Driver/pseudo-probe.c

4

Line 1 is the -funique-internal-linkage-names switch , and we are checking YESPROBE for it.

4

Line 1 is the -funique-internal-linkage-names switch , and we are checking YESPROBE for it.

Line is w/o the -funique-internal-linkage-names switch.

[wenlei]

lgtm, thanks.

clang/test/Driver/pseudo-probe.c

4

ah, sorry missed that.

clang/lib/Driver/ToolChains/Clang.cpp

if (Arg *A = getLastProfileSampleUseArg(Args)) {
       if (!llvm::sys::fs::exists(fname))
         D.Diag(diag::err_drv_no_such_file) << fname;
       else
         A->render(Args, CmdArgs);
     }
     Args.AddLastArg(CmdArgs, options::OPT_fprofile_remapping_file_EQ);
 
     if (Args.hasFlag(options::OPT_fpseudo_probe_for_profiling,
-                     options::OPT_fno_pseudo_probe_for_profiling, false))
+                     options::OPT_fno_pseudo_probe_for_profiling, false)) {
       CmdArgs.push_back("-fpseudo-probe-for-profiling");
+      // Enforce -funique-internal-linkage-names if it's not explicitly turned
+      // off.
+      if (Args.hasFlag(options::OPT_funique_internal_linkage_names,
+                       options::OPT_fno_unique_internal_linkage_names, true))
+        CmdArgs.push_back("-funique-internal-linkage-names");
+    }
   }
   RenderBuiltinOptions(TC, RawTriple, Args, CmdArgs);
 
   if (!Args.hasFlag(options::OPT_fassume_sane_operator_new,
                     options::OPT_fno_assume_sane_operator_new))
     CmdArgs.push_back("-fno-assume-sane-operator-new");
 
   // -fblocks=0 is default.

clang/test/Driver/pseudo-probe.c

 // RUN: %clang -### -fpseudo-probe-for-profiling %s 2>&1 | FileCheck %s --check-prefix=YESPROBE
 // RUN: %clang -### -fno-pseudo-probe-for-profiling %s 2>&1 | FileCheck %s --check-prefix=NOPROBE
 // RUN: %clang -### -fpseudo-probe-for-profiling -fdebug-info-for-profiling %s 2>&1 | FileCheck %s --check-prefix=CONFLICT
+// RUN: %clang -### -fpseudo-probe-for-profiling -funique-internal-linkage-names %s 2>&1 | FileCheck %s --check-prefix=YESPROBE
+// RUN: %clang -### -fpseudo-probe-for-profiling -fno-unique-internal-linkage-names %s 2>&1 | FileCheck %s --check-prefix=NONAME
 
 // YESPROBE: -fpseudo-probe-for-profiling
+// YESPROBE: -funique-internal-linkage-names
 // NOPROBE-NOT: -fpseudo-probe-for-profiling
+// NOPROBE-NOT: -funique-internal-linkage-names
+// NONAME: -fpseudo-probe-for-profiling
+// NONAME-NOT: -funique-internal-linkage-names
 // CONFLICT: invalid argument