This is an archive of the discontinued LLVM Phabricator instance.

sanitizer_common: link Synchronization.lib on Windows
ClosedPublic

Authored by dvyukov on Jul 16 2021, 10:57 AM.

Download Raw Diff

Details

Reviewers

vitalybuka
melver

Commits

rGdb29c030dfea: sanitizer_common: link Synchronization.lib on Windows

Summary

Windows bot failed with:
sanitizer_win.cpp.obj : error LNK2019: unresolved external symbol WaitOnAddress referenced in function "void cdecl sanitizer::FutexWait(struct sanitizer::atomic_uint32_t *,unsigned int)" (?FutexWait@sanitizer@@YAXPEAUatomic_uint32_t@1@I@Z)
sanitizer_win.cpp.obj : error LNK2019: unresolved external symbol WakeByAddressSingle referenced in function "void cdecl sanitizer::FutexWake(struct sanitizer::atomic_uint32_t *,unsigned int)" (?FutexWake@sanitizer@@YAXPEAUatomic_uint32_t@1@I@Z)
sanitizer_win.cpp.obj : error LNK2019: unresolved external symbol WakeByAddressAll referenced in function "void cdecl sanitizer::FutexWake(struct sanitizer::atomic_uint32_t *,unsigned int)" (?FutexWake@sanitizer@@YAXPEAUatomic_uint32_t@1@I@Z)
https://lab.llvm.org/buildbot/#/builders/127/builds/14046

According to MSDN we need to link Synchronization.lib:
https://docs.microsoft.com/en-us/windows/win32/api/synchapi/nf-synchapi-waitonaddress

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

dvyukov created this revision.Jul 16 2021, 10:57 AM

Herald added a subscriber: jfb. · View Herald TranscriptJul 16 2021, 10:57 AM

dvyukov requested review of this revision.Jul 16 2021, 10:57 AM

Herald added a project: Restricted Project. · View Herald TranscriptJul 16 2021, 10:57 AM

Herald added a subscriber: Restricted Project. · View Herald Transcript

This revision was not accepted when it landed; it landed in state Needs Review.Jul 16 2021, 10:59 AM

This revision was landed with ongoing or failed builds.

Closed by commit rGdb29c030dfea: sanitizer_common: link Synchronization.lib on Windows (authored by dvyukov). · Explain Why

This revision was automatically updated to reflect the committed changes.

dvyukov added a commit: rGdb29c030dfea: sanitizer_common: link Synchronization.lib on Windows.

Harbormaster completed remote builds in B114548: Diff 359386.Jul 16 2021, 11:35 AM

Revision Contents

Path

Size

compiler-rt/

lib/

sanitizer_common/

sanitizer_win.cpp

3 lines

Diff 359388

compiler-rt/lib/sanitizer_common/sanitizer_win.cpp

	Show All 38 Lines
	// GUID must be the same in utils/AddressSanitizerLoggingProvider.wprp			// GUID must be the same in utils/AddressSanitizerLoggingProvider.wprp
	TRACELOGGING_DEFINE_PROVIDER(g_asan_provider, "AddressSanitizerLoggingProvider",			TRACELOGGING_DEFINE_PROVIDER(g_asan_provider, "AddressSanitizerLoggingProvider",
	(0x6c6c766d, 0x3846, 0x4e6a, 0xa4, 0xfb, 0x5b,			(0x6c6c766d, 0x3846, 0x4e6a, 0xa4, 0xfb, 0x5b,
	0x53, 0x0b, 0xd0, 0xf3, 0xfa));			0x53, 0x0b, 0xd0, 0xf3, 0xfa));
	#else			#else
	#define TraceLoggingUnregister(x)			#define TraceLoggingUnregister(x)
	#endif			#endif

				// For WaitOnAddress
				# pragma comment(lib, "Synchronization.lib")

	// A macro to tell the compiler that this part of the code cannot be reached,			// A macro to tell the compiler that this part of the code cannot be reached,
	// if the compiler supports this feature. Since we're using this in			// if the compiler supports this feature. Since we're using this in
	// code that is called when terminating the process, the expansion of the			// code that is called when terminating the process, the expansion of the
	// macro should not terminate the process to avoid infinite recursion.			// macro should not terminate the process to avoid infinite recursion.
	#if defined(__clang__)			#if defined(__clang__)
	# define BUILTIN_UNREACHABLE() __builtin_unreachable()			# define BUILTIN_UNREACHABLE() __builtin_unreachable()
	#elif defined(__GNUC__) && \			#elif defined(__GNUC__) && \
	(__GNUC__ > 4 \|\| (__GNUC__ == 4 && __GNUC_MINOR__ >= 5))			(__GNUC__ > 4 \|\| (__GNUC__ == 4 && __GNUC_MINOR__ >= 5))
	▲ Show 20 Lines • Show All 1,124 Lines • Show Last 20 Lines