[libc++] CI: Run -std=c++03 on Clang ToT

[ldionne]

Rebase to trigger CI.

[ldionne]

Print the compiler version for debugging

[ldionne]

Poke CI again -- did the nodes update their Clang ToT yet?

[ldionne]

Poke CI: did the bots update to ToT?

[ldionne]

Poke CI - I think the bots should have updated now.

[ldionne]

@mizvekov For some reason, it looks like the tests are still failing with Clang ToT, even with all your patches applied. Any idea?

We need to fix this for the LLVM 13 release, or users will be unable to compile in C++03 mode (cause libc++ won't work).

[mizvekov]

In D106104#2905786, @ldionne wrote:

@mizvekov For some reason, it looks like the tests are still failing with Clang ToT, even with all your patches applied. Any idea?

We need to fix this for the LLVM 13 release, or users will be unable to compile in C++03 mode (cause libc++ won't work).

It's working on compiler explorer / clang trunk: https://godbolt.org/z/E6xP4qfPa

Maybe that bot has very outdated clang?

[ldionne]

In D106104#2905818, @mizvekov wrote:

In D106104#2905786, @ldionne wrote:

@mizvekov For some reason, it looks like the tests are still failing with Clang ToT, even with all your patches applied. Any idea?

We need to fix this for the LLVM 13 release, or users will be unable to compile in C++03 mode (cause libc++ won't work).

It's working on compiler explorer / clang trunk: https://godbolt.org/z/E6xP4qfPa

Maybe that bot has very outdated clang?

Hmm, interesting, thanks for checking. I think the bots should be updating their image automatically, but perhaps that doesn't work as intended. I'm trying to make them refresh their Docker image here: 496a3815f43d20853a4fad77c7d70414385c3b06

[ldionne]

Poke CI

[ldionne]

Okay, looks like I guessed correctly. The Docker images were being cached and had not updated for a while. Changing the Dockerfile forced them to rebuild and the C++03 job passed. I'll ship this now.

libcxx/utils/ci/run-buildbot

 function check-cxx-benchmarks() {
     echo "--- Running the benchmarks"
     ${NINJA} -vC "${BUILD_DIR}" check-cxx-benchmarks
 }
 
 # Print the version of a few tools to aid diagnostics in some cases
 ${CMAKE} --version
 ${NINJA} --version
+c++ --version
 
 case "${BUILDER}" in
 check-format)
     clean
     echo "+++ Checking formatting"
     # We need to set --extensions so that clang-format checks extensionless files.
     mkdir -p ${BUILD_DIR}
     git-clang-format \
check-generated-output)
     # Reject patches that introduce non-ASCII characters or hard tabs.
     # Depends on LC_COLLATE set at the top of this script.
     ! grep -rn '[^ -~]' libcxx/include/ || false
 
     # Reject patches that introduce dependency cycles in the headers.
     python3 libcxx/utils/graph_header_deps.py >/dev/null
 ;;
 generic-cxx03)
-    # TODO: Switch to compiling with Clang ToT once issues with https://reviews.llvm.org/D104500 are resolved.
-    export CC=clang-12
-    export CXX=clang++-12
     clean
     generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Generic-cxx03.cmake" \
                    -DLIBCXX_TEST_CONFIG="${MONOREPO_ROOT}/libcxx/test/configs/libcxx-trunk-shared.cfg.in"
     check-cxx-cxxabi
     check-abi-list
 ;;
 generic-cxx11)
     clean