Added information stored in PipelineOptions and the MCSubtargetInfo.
Should this information be also printed in the "classic" report? This would require updating almost all tests.
Paths
| Differential D106077
[llvm-mca] Store extra information about the driver flags used for the simulation ClosedPublic Authored by markoshorro on Jul 15 2021, 9:37 AM.
Details Summary Added information stored in PipelineOptions and the MCSubtargetInfo. Should this information be also printed in the "classic" report? This would require updating almost all tests.
Diff Detail
Unit TestsFailed Event Timeline
Comment Actions Added new test for output with custom parameters. Only printing parameters if values are not default. Comment Actions A couple of minor nits. Otherwise it LGTM.
Comment Actions Minor edits for readability and avoiding unnecessary information when inorder simulation This revision was not accepted when it landed; it landed in state Needs Review.Jul 16 2021, 12:19 AM This revision was landed with ongoing or failed builds. Closed by commit rG77f2f0f9b7c7: [llvm-mca][JSON] Store extra information about driver flags used for the… (authored by markoshorro). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 359068 llvm/test/tools/llvm-mca/JSON/X86/instruction-tables-multiple-anonymous-regions.s
llvm/test/tools/llvm-mca/JSON/X86/instruction-tables-multiple-regions.s
llvm/test/tools/llvm-mca/JSON/X86/views-custom-parameters.s
llvm/test/tools/llvm-mca/JSON/X86/views-multiple-anonymous-regions.s
llvm/test/tools/llvm-mca/JSON/X86/views-multiple-region.s
llvm/test/tools/llvm-mca/JSON/X86/views.s
llvm/tools/llvm-mca/PipelinePrinter.h
llvm/tools/llvm-mca/PipelinePrinter.cpp
llvm/tools/llvm-mca/llvm-mca.cpp
|
I think that we should just ignore flags like -dispatch, -squeue, -lqueue, etc. if their value hasn't been changed by the user. I suggest to only report flags whose value doesn't correspond to their default.
The only exceptions would be mcpu/march/mtriple which (at least in my opinion) should always be present for completeness.