This is an archive of the discontinued LLVM Phabricator instance.

Differential D105954

[scudo] Don't enabled MTE for small alignment
ClosedPublic

Authored by vitalybuka on Jul 13 2021, 6:12 PM.

Details

Reviewers
pcc
saugustine
Commits
rG14362bf1b258: [scudo] Don't enabled MTE for small alignment

Diff Detail

Event Timeline

vitalybuka created this revision.Jul 13 2021, 6:12 PM
Herald added a subscriber: cryptoad. · View Herald TranscriptJul 13 2021, 6:12 PM
vitalybuka requested review of this revision.Jul 13 2021, 6:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2021, 6:12 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B113885: Diff 358472.Jul 13 2021, 6:42 PM
saugustine accepted this revision.Jul 14 2021, 11:41 AM
This revision is now accepted and ready to land.Jul 14 2021, 11:41 AM
pcc accepted this revision.Jul 14 2021, 12:02 PM

LGTM

Closed by commit rG14362bf1b258: [scudo] Don't enabled MTE for small alignment (authored by vitalybuka). · Explain WhyJul 14 2021, 12:04 PM
This revision was automatically updated to reflect the committed changes.
vitalybuka added a commit: rG14362bf1b258: [scudo] Don't enabled MTE for small alignment.

Revision Contents

PathSize
compiler-rt/
lib/
scudo/
standalone/
3 lines

Diff 358691

compiler-rt/lib/scudo/standalone/memtag.h

Show First 20 Lines • Show All 313 Lines • ▼ Show 20 Lines
inline void *addFixedTag(void *Ptr, uptr Tag) { inline void *addFixedTag(void *Ptr, uptr Tag) {
return reinterpret_cast<void *>( return reinterpret_cast<void *>(
addFixedTag(reinterpret_cast<uptr>(Ptr), Tag)); addFixedTag(reinterpret_cast<uptr>(Ptr), Tag));
} }
template <typename Config> template <typename Config>
inline constexpr bool allocatorSupportsMemoryTagging() { inline constexpr bool allocatorSupportsMemoryTagging() {
return archSupportsMemoryTagging() && Config::MaySupportMemoryTagging; return archSupportsMemoryTagging() && Config::MaySupportMemoryTagging &&
(1 << SCUDO_MIN_ALIGNMENT_LOG) >= archMemoryTagGranuleSize();
} }
} // namespace scudo } // namespace scudo
#endif #endif