Page MenuHomePhabricator

[lld/mac] Implement -application_extension
ClosedPublic

Authored by thakis on Jul 12 2021, 8:09 AM.

Details

Reviewers
int3
gkm
Group Reviewers
Restricted Project
Commits
rGf21801dab249: [lld/mac] Implement -application_extension

Diff Detail

Event Timeline

thakis created this revision.Jul 12 2021, 8:09 AM
Herald added a reviewer: gkm. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: dang. · View Herald Transcript
thakis requested review of this revision.Jul 12 2021, 8:09 AM
int3 accepted this revision.Jul 12 2021, 10:09 AM

lgtm

lld/MachO/Options.td
692
lld/test/MachO/application-extension.s
47
This revision is now accepted and ready to land.Jul 12 2021, 10:09 AM
int3 added inline comments.Jul 12 2021, 10:28 AM
lld/test/MachO/application-extension.s
20

nit: s/.so/.dylib/

thakis marked 2 inline comments as done.Jul 12 2021, 10:44 AM

Thanks!

lld/test/MachO/application-extension.s
20

Hm, I thought it's custom to call -dylibs .dylib and -bundles .so?

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2021, 10:44 AM
int3 added inline comments.Jul 12 2021, 10:50 AM
lld/test/MachO/application-extension.s
20

oh is it? alright then