Page MenuHomePhabricator

[scudo] Check if we use __clang_major__ >= 12
ClosedPublic

Authored by vitalybuka on Jul 9 2021, 12:27 PM.

Details

Summary

This makes sure we have support for MTE instructions.
Later the check can be extended to support MTE on other compilers.

Diff Detail

Event Timeline

vitalybuka created this revision.Jul 9 2021, 12:27 PM
vitalybuka requested review of this revision.Jul 9 2021, 12:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2021, 12:27 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka edited the summary of this revision. (Show Details)Jul 9 2021, 12:28 PM
pcc added inline comments.Jul 9 2021, 12:33 PM
compiler-rt/lib/scudo/standalone/memtag.h
58

Don't you also need it here?

vitalybuka marked an inline comment as done.

fix

pcc accepted this revision.Jul 9 2021, 4:33 PM

LGTM

compiler-rt/lib/scudo/standalone/memtag.h
21

#if (__clang_major__ >= 12 && defined(__aarch64__)) || defined(SCUDO_FUZZ)

This revision is now accepted and ready to land.Jul 9 2021, 4:33 PM
vitalybuka marked an inline comment as done.Jul 9 2021, 5:47 PM
vitalybuka updated this revision to Diff 357676.Jul 9 2021, 5:48 PM

SCUDO_FUZZ ignores clang_major

This revision was landed with ongoing or failed builds.Jul 9 2021, 5:48 PM
This revision was automatically updated to reflect the committed changes.