Page MenuHomePhabricator

[Coroutine] Record the elided coroutines
ClosedPublic

Authored by ChuanqiXu on Jul 7 2021, 9:45 PM.

Details

Summary

This is follow up for D105095. In D105095, we recorded how many coroutine got elided.
Then in practice, it is helpful to know the accurate coroutine got elided.

I think it is helpful for others who use a large projects.

Test Plan: check-llvm

Diff Detail

Event Timeline

ChuanqiXu created this revision.Jul 7 2021, 9:45 PM
ChuanqiXu requested review of this revision.Jul 7 2021, 9:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2021, 9:45 PM

gentle ping~

fix lint?

gentle ping~

fix lint?

I am not sure if I understand your point correctly. The intent of the diff is going to record the coroutines got elided. There are options to dump informations to specific file like info-output-file in Timer.cpp. So I guess we can do similar things in coroutine.

gentle ping~

fix lint?

I am not sure if I understand your point correctly. The intent of the diff is going to record the coroutines got elided. There are options to dump informations to specific file like info-output-file in Timer.cpp. So I guess we can do similar things in coroutine.

I mean fix the lint warning.

ChuanqiXu updated this revision to Diff 361885.Jul 26 2021, 7:11 PM

Address comments.

lxfind added inline comments.Jul 26 2021, 7:24 PM
llvm/lib/Transforms/Coroutines/CoroElide.cpp
28

Shouldn't this be under NDEBUG too?

ChuanqiXu updated this revision to Diff 361889.Jul 26 2021, 7:54 PM

Address comments.

lxfind accepted this revision.Jul 26 2021, 9:42 PM
This revision is now accepted and ready to land.Jul 26 2021, 9:42 PM
This revision was landed with ongoing or failed builds.Jul 26 2021, 10:15 PM
This revision was automatically updated to reflect the committed changes.