Page MenuHomePhabricator

[lld/mac] Implement -final_output
ClosedPublic

Authored by thakis on Jul 5 2021, 4:50 PM.

Details

Reviewers
int3
gkm
Group Reviewers
Restricted Project
Commits
rG2c25f39fcce4: [lld/mac] Implement -final_output
Summary

This is one of two flags clang passes to the linker when giving calling
clang with multiple -arch flags.

I think it'd make sense to also use finalOutput instead of outputFile
in CodeSignatureSection() and when replacing @executable_path, but
ld64 doesn't do that, so I'll at least put those in separate commits.

Diff Detail

Event Timeline

thakis created this revision.Jul 5 2021, 4:50 PM
Herald added a reviewer: gkm. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: dang. · View Herald Transcript
thakis requested review of this revision.Jul 5 2021, 4:50 PM
int3 accepted this revision.Jul 5 2021, 4:59 PM
int3 added inline comments.
lld/test/MachO/final-output.s
9

how about llvm-objdump --macho --dylib-id?

This revision is now accepted and ready to land.Jul 5 2021, 4:59 PM

Thanks!

lld/test/MachO/final-output.s
9

Turns out llvm-otool -D does that too, so switched to that :)

This revision was landed with ongoing or failed builds.Jul 5 2021, 5:06 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2021, 5:06 PM