Page MenuHomePhabricator

[lld/mac] Implement -umbrella
ClosedPublic

Authored by thakis on Jul 5 2021, 3:52 PM.

Details

Reviewers
int3
gkm
Group Reviewers
Restricted Project
Commits
rGdb64306d9913: [lld/mac] Implement -umbrella
Summary

I think this is an old way for doing what is done with
-reexport_library these days, but it's e.g. still used in libunwind's
build (the opensource.apple.com one, not the llvm one).

Diff Detail

Event Timeline

thakis created this revision.Jul 5 2021, 3:52 PM
Herald added a reviewer: gkm. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: dang. · View Herald Transcript
thakis requested review of this revision.Jul 5 2021, 3:52 PM
thakis added inline comments.
lld/MachO/Driver.cpp
1126

ld64 doesn't have this warning, but it seems maybe useful.

ld64 accepts the empty string as -umbrella flag and then writes an empty string to the load command. We silently ignore an empty arg. Writing an empty string to the output is never useful. We could warn on it, I suppose, but I don't know if that ever happens…

int3 accepted this revision.Jul 5 2021, 4:05 PM

Thanks!

This revision is now accepted and ready to land.Jul 5 2021, 4:05 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2021, 5:06 PM