Page MenuHomePhabricator

[InstCombine] visitUnreachableInst(): iteratively erase instructions leading to unreachable
ClosedPublic

Authored by lebedev.ri on Jul 2 2021, 2:33 AM.

Details

Summary

In the original review D87149 it was mentioned that this approach was tried,
and it lead to infinite combine loops, but i'm not seeing anything like that now,
neither in the check-llvm, nor on some codebases i tried.

Diff Detail

Event Timeline

lebedev.ri created this revision.Jul 2 2021, 2:33 AM
lebedev.ri requested review of this revision.Jul 2 2021, 2:33 AM
spatel accepted this revision.Jul 2 2021, 7:13 AM

LGTM - I don't have any other notes about problems I saw in the earlier patch.

This revision is now accepted and ready to land.Jul 2 2021, 7:13 AM

LGTM - I don't have any other notes about problems I saw in the earlier patch.

I see. Thank you for double-checking.